-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README. Add development section #662
Conversation
Actually I myself don't even remember what I've meant back there). But that's a good shot you've made, let's merge it anyway. |
Why is this failing tests 😭 Can you please re-run @yaroslavyaroslav? Don't seem to have permission. |
I need a bit time to figures out how set those repos permissions well enough for everyone. |
I've got a cool life hack btw: If you type within PR body |
|
||
// To run | ||
$ ganache | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop this last empty line please as right now it just takes more space in the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``` | ||
|
||
This will create a local blockchain and also some test accounts that are used throughout our tests. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add a note:
Make sure that ganache
is running on its default port 8546
. To change the port in test cases locate LocalTestCase.swift
and modify the static url
variable.
I'll open a new PR with updates I've suggested. |
Adds a development section to explain how to run the local blockchain (ganache) for testing.
Not sure if that's also what you meant with #431 @yaroslavyaroslav