Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README. Add development section #662

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Update README. Add development section #662

merged 1 commit into from
Nov 10, 2022

Conversation

janndriessen
Copy link
Collaborator

@janndriessen janndriessen commented Nov 10, 2022

Adds a development section to explain how to run the local blockchain (ganache) for testing.

Not sure if that's also what you meant with #431 @yaroslavyaroslav

@janndriessen janndriessen marked this pull request as ready for review November 10, 2022 11:47
@yaroslavyaroslav
Copy link
Collaborator

Actually I myself don't even remember what I've meant back there). But that's a good shot you've made, let's merge it anyway.

@janndriessen
Copy link
Collaborator Author

janndriessen commented Nov 10, 2022

Why is this failing tests 😭 Can you please re-run @yaroslavyaroslav? Don't seem to have permission.

@yaroslavyaroslav
Copy link
Collaborator

I need a bit time to figures out how set those repos permissions well enough for everyone.

@yaroslavyaroslav yaroslavyaroslav merged commit 863e7ed into web3swift-team:develop Nov 10, 2022
@yaroslavyaroslav
Copy link
Collaborator

I've got a cool life hack btw: If you type within PR body Closes #431 then on merging PR Issue would be closed automatically. So please use it as broadly as it's intersects with any issues.


// To run
$ ganache

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this last empty line please as right now it just takes more space in the README.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2022-11-10 at 15 38 58

```

This will create a local blockchain and also some test accounts that are used throughout our tests.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a note:

Make sure that ganache is running on its default port 8546. To change the port in test cases locate LocalTestCase.swift and modify the static url variable.

@JeneaVranceanu
Copy link
Collaborator

I'll open a new PR with updates I've suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants