fix!: web3 error output fix #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeneaVranceanu
commented
Nov 11, 2022
| @@ -25,7 +25,7 @@ public enum Web3Error: Error { | |||
| case generalError(err: Error) | |||
| case unknownError | |||
|
|
|||
| public var errorDescription: String { | |||
| public var errorDescription: String? { | |||
There was a problem hiding this comment.
Changed type to comply with LocalizedError protocol and make localizedDescription return value from errorDescription.
There was a problem hiding this comment.
Thou it's a bit confusing for me when I've got error messages on my language in console. Also it's usually awfully translated. But anyway, this is must.
yaroslavyaroslav
requested changes
Nov 11, 2022
|
|
||
| class Web3ErrorTests: XCTestCase { | ||
|
|
||
| func test_web3ErrorReturnsExpectedDescription() { |
There was a problem hiding this comment.
This one is a something, but anyway it's violates camelCase convention of tests naming that is used here
yaroslavyaroslav
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains breaking change! Changed type of
errorDescription: StringtoerrorDescription: String?.This change is easy to "fix" but still it's breaking.
Improved output of the error when calling
error.localizedDescriptionand the error is of typeWeb3Error.Before (useless output):
After (copied log from a test case):