Fix validation in SPI package list

[finestructure]

The Swift Package Index package list validation runs on Linux, which prevents this package from being added due to:

ERROR: package dump failed: error: '852dd406-2b6d-4101-aba4-608728cac732': Invalid manifest
/tmp/852DD406-2B6D-4101-ABA4-608728CAC732/Package.swift:35:22: error: cannot find 'excludeFiles' in scope
            exclude: excludeFiles,
                     ^~~~~~~~~~~~
error: invalid manifests at [<AbsolutePath:"/tmp/852DD406-2B6D-4101-ABA4-608728CAC732">]

[yaroslavyaroslav]

That bit of code, that you're fixing actually was made by purpose, since the solution that you've provided, which is actually was there in the near past, failed to build this package on Linux.

But anyway, currently such file, that this line excludes, just doesn't exists anymore. Please change this PR to just drop excludedFiles at all from SPM config and it'll be merged.

[yaroslavyaroslav]

Either leave us a hint that you're out of this and I'll provide such fix by myself in nearest planed release, which will within 2 weeks or so.

[finestructure]

Hey, I'm not sure I follow - I don't think I've provided any changes previously or have I? 😅

I'm not sure what fix you have in mind but as is the Package.swift manifest is invalid on Linux. My fix should address that and I've also pushed another change to fix the type.

This allows swift build to run but it fails for other reasons:

/host/Sources/Core/Utility/Data+Extension.swift:49:47: error: cannot find 'kSecRandomDefault' in scope
                    return SecRandomCopyBytes(kSecRandomDefault, length, pointer)
                                              ^~~~~~~~~~~~~~~~~
/host/Sources/Core/Utility/Data+Extension.swift:54:59: error: cannot find 'errSecSuccess' in scope
            if let notNilResult = result, notNilResult == errSecSuccess {
                                                          ^~~~~~~~~~~~~

Hope that helps!

[JeneaVranceanu]

@finestructure Hi there. I think what @yaroslavyaroslav meant is to completely remove excludeFiles as there is no ./Browser/BrowserViewController.swift in the project anymore.

[finestructure]

Just to clarify why I submitted the change: apparently the repo was moved to a different Github account. This was picked up by our nightly job and it removed the old package and added this as a new package in the index. However, because the Package.swift file is invalid on Linux, it cannot currently be added to the index. That's what I was trying to fix.

[finestructure]

@finestructure Hi there. I think what @yaroslavyaroslav meant is to completely remove excludeFiles as there is no ./Browser/BrowserViewController.swift" in the project anymore.

For macOS as well you mean? Ok, can do.

[JeneaVranceanu]

Correct.
This file was removed some time ago. This is the Bridge directory now:

[JeneaVranceanu]

@yaroslavyaroslav For easy tracking of this related to Linux I've added a tag for it. Feel free to change it or remove if you find it unnecessary.

[yaroslavyaroslav]

@finestructure previously I've meant that your PR actually made a roll back some recent PR which added changes within Package.swift. None of them would've made by you.

But anyway the PR as it is now are the thing that we've planned to do by ourselves, just not considered it in a way of urgency.

Anyway, thank you for your effort, and for you contribution as well!

[yaroslavyaroslav]

Ah, @finestructure point me out please how urgent is to release those changes? E.g. merge them in master and tag as new version?

[finestructure]

No release required! This is just about Package.swift on the default branch.