Crop all print from Tests and Sources.
#673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavyaroslav
changed the title
print from Tests.print from Tests and Sources.
janndriessen
previously approved these changes
Nov 17, 2022
|
Yep, I'm not rushing with this one. |
JeneaVranceanu
previously approved these changes
Nov 18, 2022
JeneaVranceanu
dismissed stale reviews from janndriessen and themself
via
68a75f5
|
@janndriessen Conflict was resolved. Re-approve required. |
JeneaVranceanu
previously approved these changes
Nov 18, 2022
JeneaVranceanu
requested changes
Nov 18, 2022
| @@ -124,6 +124,6 @@ | |||
| // let userAddress = EthereumAddress("0xe22b8979739D724343bd002F9f432F5990879901")! | |||
| // let tokenBalance = try await token.read("balanceOf", parameters: [userAddress] as [AnyObject])!.decodedData() | |||
| // guard let bal = tokenBalance["0"] as? BigUInt else {return XCTFail()} | |||
| // print(String(bal)) | |||
| // ) | |||
| // } | |||
| // } | |||
There was a problem hiding this comment.
Maybe we should drop this file.
Worth taking a look at what is useful inside and if we don't already have similar tests that weren't using promises.
JeneaVranceanu
requested changes
Nov 18, 2022
There was a problem hiding this comment.
The last thing before approval: please, go over all tests and replace the following ->
if case .notYetProcessed = receipt.status {
return
}Must be replaced with
if case .notYetProcessed = receipt.status {
throw Web3Error.processingError(desc: "Transaction is not yet complete")
}
|
@JeneaVranceanu sure, I'm no rushing with this one, since it'll be merger after @pharms-eth PRs, which I think would be merged within several weeks or so. |
yaroslavyaroslav
force-pushed
the
clean-tests-output
branch
from
d4eb962
to
5e61fcc
Compare
JeneaVranceanu
approved these changes
Dec 14, 2022
janndriessen
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #639