Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updated /skywinder to /web3swift-team #708

Merged
merged 6 commits into from
Dec 14, 2022
Merged

chore: updated /skywinder to /web3swift-team #708

merged 6 commits into from
Dec 14, 2022

Conversation

JeneaVranceanu
Copy link
Collaborator

Summary of Changes

Updated links in README.md

Test Data or Screenshots

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@JeneaVranceanu JeneaVranceanu self-assigned this Dec 12, 2022
janndriessen
janndriessen previously approved these changes Dec 12, 2022
View reviewed changes
@JeneaVranceanu
Copy link
Collaborator Author

@janndriessen @yaroslavyaroslav Wait, do not merge.
I'll double check that all links work.

@janndriessen
Copy link
Collaborator

@janndriessen @yaroslavyaroslav Wait, do not merge. I'll double check that all links work.

Just saw LICENSE is missing the .md. @JeneaVranceanu

@yaroslavyaroslav
Copy link
Collaborator

@janndriessen @yaroslavyaroslav Wait, do not merge. I'll double check that all links work.

Just saw LICENSE is missing the .md. @JeneaVranceanu

This one could be by design, like GitHub suggest you this as one of the options

@JeneaVranceanu
Copy link
Collaborator Author

So besides the License the link to CI is also down:
Screenshot 2022-12-13 at 19 19 23

@JeneaVranceanu
Copy link
Collaborator Author

And it was down for some time.

JeneaVranceanu
JeneaVranceanu commented Dec 13, 2022
View reviewed changes
README.md
[![Platform](https://img.shields.io/cocoapods/p/web3swift.svg?style=flat)](http://cocoapods.org/pods/web3.swift.pod)
[![CocoaPods Compatible](https://img.shields.io/cocoapods/v/web3.swift.pod.svg?style=flat)](http://cocoapods.org/pods/web3.swift.pod)
[![Platform](https://img.shields.io/cocoapods/p/web3swift?style=flat)](http://cocoapods.org/pods/web3swift)
[![CocoaPods Compatible](https://img.shields.io/cocoapods/v/web3swift?style=flat)](http://cocoapods.org/pods/web3swift)
Copy link
Collaborator Author

@JeneaVranceanu JeneaVranceanu Dec 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform and CocoaPods Compatible visuals breaks sometimes. And it looks like it's not related to web3swift project only:

Screenshot 2022-12-13 at 19 34 54

This 2.2.1 version is a screenshot of the version of web3.swift.pod library, not web3swift. But this is what we used.
Screenshot 2022-12-13 at 19 32 39

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol

@JeneaVranceanu
Copy link
Collaborator Author

@janndriessen Thanks for checking the URLs. Fixed LICENSE link. Just needed to add .md at the end of the link.

Note that there are cocoapod related badges that are broken. Sometimes they load but if the timeout is passed (around 5 seconds) - the placeholder is shown.
I guess it could work or not depending on where you are located but for me it is not consistent. We should leave that for now and will see if it will be fixed. Only cocoapod related badges load slowly, the rest loads instantly.

JeneaVranceanu
JeneaVranceanu commented Dec 13, 2022
View reviewed changes
README.md
[![Carthage Compatible](https://img.shields.io/badge/Carthage-compatible-4BC51D.svg?style=flat)](https://github.com/Carthage/Carthage)
[![License](https://img.shields.io/cocoapods/l/web3swift.svg?style=flat)](http://cocoapods.org/pods/web3.swift.pod)
[![License](https://img.shields.io/cocoapods/l/web3swift.svg?style=flat)](https://github.com/web3swift-team/web3swift/blob/master/LICENSE.md)
[![support](https://brianmacdonald.github.io/Ethonate/svg/eth-support-blue.svg)](https://brianmacdonald.github.io/Ethonate/address#0xe22b8979739d724343bd002f9f432f5990879901)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaroslavyaroslav Do you know whose address is this?
It looks like it should be removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it wasn't clear but looks like it's related to GitCoin grants.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeneaVranceanu I'm kinda surprised that we have carthage badge, since we've dropped it. Could you please remove it?

About that address, I guess it's the address of @skywinder — the founder of this lib, he's messing with the gitcoin a long time ago. But that's just a guess.

@JeneaVranceanu
Copy link
Collaborator Author

JeneaVranceanu commented Dec 13, 2022 •
edited
Loading

Thanks for reviewing. I've added a few fixes, looks good now.
Please, take a look at the last 3 commits.
@yaroslavyaroslav @janndriessen

@JeneaVranceanu
Copy link
Collaborator Author

@yaroslavyaroslav Carthage badge removed.
No other changes are planned for this PR.

janndriessen
janndriessen approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@janndriessen janndriessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it.

@yaroslavyaroslav yaroslavyaroslav merged commit 28f7531 into develop Dec 14, 2022
@yaroslavyaroslav yaroslavyaroslav deleted the chore/link-update branch December 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslavyaroslav yaroslavyaroslav yaroslavyaroslav approved these changes

@janndriessen janndriessen janndriessen approved these changes

Assignees

@JeneaVranceanu JeneaVranceanu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeneaVranceanu @janndriessen @yaroslavyaroslav