Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC20.transaction doesn't assigns to WriteOperation.transaction property fix #713

Merged
merged 2 commits into from
Jan 13, 2023
Merged

ERC20.transaction doesn't assigns to WriteOperation.transaction property fix #713

merged 2 commits into from
Jan 13, 2023

Commits on Dec 15, 2022

  1. This one fixing the ERC20 implementation bug, where `ERC20.transactio… 

    …n` never assigns to `Contract.transaction` for any given method that writes on chain.

Obviously it's a bug spreading all over the `Token` implementation. So this fix should be applied to all `ERC*.swift` methods that returns `WriteOperation`.

This is the special case of web3swift-team#712.

Closes web3swift-team#711
    @yaroslavyaroslav
    yaroslavyaroslav committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    62f3e97 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Fixing review issues.

    @yaroslavyaroslav
    yaroslavyaroslav committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    aa4d563 View commit details
    Browse the repository at this point in the history