ENSTests added assertions #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janndriessen
reviewed
Jan 5, 2023
| let ttl = try await ens?.registry.getTTL(node: domain) | ||
|
|
||
| let ttl = try await ens.registry.getTTL(node: domain) | ||
| XCTAssertGreaterThanOrEqual(ttl, 0) |
There was a problem hiding this comment.
Your explanation makes sense here. Just one question so since it's try and the test function throws, this test would fail if there is an issue with getting the TTL for the domain, correct?
There was a problem hiding this comment.
Yes, getTTL will throw if arises any issue:
- if nameHash couldn't be obtained
- if transaction couldn't be created
- if calling contract the result is nil
- if the result doesn't contain "0" key
janndriessen
approved these changes
Jan 5, 2023
JeneaVranceanu
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added assertions to ENSTests, related to #716
testDomainNormalizationlacks the assertion, easy to fix.testTTLlacks also the assertion, I were checking EIP137 and doing some checks with other lib(web3js) and the TTL was zero for "somename.eth". The point here to add this assertion is:The only way to verify a non zero TTL is to change the cache time(TTL) via setter and then run the getter, but being in the mainnet it will generate costs in terms of eth. What do you think?
Test Data or Screenshots
By submitting this pull request, you are confirming the following:
developbranch.