Rename default options #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeneaVranceanu
approved these changes
Jan 15, 2023
| @@ -107,7 +106,7 @@ public class ENS { | |||
| guard isAddrSupports else { | |||
| throw Web3Error.processingError(desc: "Address isn't supported") | |||
| } | |||
| var options = options ?? defaultOptions | |||
| var options = options ?? defaultTransaction | |||
There was a problem hiding this comment.
It's better now than it was before that's for sure but the API of class ENS that has functions which accept transactions by the name options is just making things look weird.
I'm accepting this PR and will create a new issue that must be handled in v4.0 to alter that API and rename all options to transaction at least.
There was a problem hiding this comment.
Was thinking the same when I saw it and thought, unfortunately, I can't change it without breaking the API. 😅
yaroslavyaroslav
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes #728
defaultOptionstodefaultTransactionon multiple ENS-related classes.By submitting this pull request, you are confirming the following:
developbranch.