fix: attempt to encode uint with a negative value results in a crash #752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Update
The initial bug was caught by mistake by using older version of the web3swift library.
But nonetheless an encoding bug was fixed: passing negative value to
ABIEncoder.encodeSingleType
with a type.uint
must returnnil
.For example, web3js produces
Uncaught Error: value out-of-bounds
for such cases. We are returningnil
for now.Attempts to encode a negative number with ParameterType
.uint(...)
resulted in a crash.The fix is located inABIEncoder.convertToBigUInt
.Test Data or Screenshots
By submitting this pull request, you are confirming the following:
develop
branch.