Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: description of transaction doesn't return from #783

Merged
merged 5 commits into from
Feb 28, 2023
Merged

Minor: description of transaction doesn't return from #783

merged 5 commits into from
Feb 28, 2023

Conversation

albertopeam
Copy link
Contributor

Summary of Changes

added EthereumAddress conformance to CustomStringConvertible.
added sender to CustomStringConvertible for CodableTransaction

Fixes # (if applicable - add the number of issue this PR addresses)
Related to #766

Test Data or Screenshots

Added a pair of tests to verify that the data is appended, not verified the content itself.

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@albertopeam
added EthereumAddress conformance to CustomStringConvertible. added s…
58c12c3 
…ender to CustomStringConvertible for CodableTransaction
@albertopeam albertopeam mentioned this pull request Feb 20, 2023
Open
janndriessen
janndriessen approved these changes Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@janndriessen janndriessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. 🌟

@JeneaVranceanu
Copy link
Collaborator

@albertopeam
About the address having characters in upper and lower case: when an address has upper and lower case letters it means it was checksummed. Checksumming an address is basically an additional step of validation.

https://coincodex.com/article/2078/ethereum-address-checksum-explained/
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.md

@JeneaVranceanu JeneaVranceanu merged commit 8cb9a20 into web3swift-team:develop Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeneaVranceanu JeneaVranceanu JeneaVranceanu approved these changes

@janndriessen janndriessen janndriessen approved these changes

@yaroslavyaroslav yaroslavyaroslav yaroslavyaroslav left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@albertopeam @JeneaVranceanu @janndriessen @yaroslavyaroslav