Use liberal and semver-correct version string for dependencies. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"latest" was used previously which worked in `npm install`. The reason for that is the registry (http://registry.npmjs.org/) can deal with both version specifications as well as tags. "latest" has a special meaning of "latest published package" as can be seen here: http://registry.npmjs.org/webrtc.io/latest However, the string "latest" is not a semver-recognised (http://semver.org/) version specification. When `npm shrinkwrap` or `npm ls` is used within a parent package/repository, both commands fail as the dependencies are not met, e.g.: $ npm install semver $ semver -v '0.0.1' -r 'latest' [ no output, i.e., expression failed ] $ semver -v '0.2.3' -r '>= 0.0.0' 0.2.3 By using a more liberal (yet very generic) version specification, the installed version is ensured to always be the latest available in the registry. In addition, any semver expressions will also parse.
Member
|
Makes sense. We may want more limiting versions later, but I don't anticipate breaking problems in the future; we use very simple functionality. Thanks a bunch! |
sarenji
added a commit
that referenced
this pull request
Dec 14, 2012
Use liberal and semver-correct version string for dependencies.
ajbogh
pushed a commit
to ajbogh/webRTC.io
that referenced
this pull request
Mar 26, 2014
Connect WebSocket relative to window.location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"latest" was used previously which worked in
npm install. The reasonfor that is the registry (http://registry.npmjs.org/) can deal with both
version specifications as well as tags. "latest" has a special meaning
of "latest published package" as can be seen here:
However, the string "latest" is not a semver-recognised
(http://semver.org/) version specification. When
npm shrinkwrapornpm lsis used within a parent package/repository, both commands failas the dependencies are not met, e.g.:
By using a more liberal (yet very generic) version specification, the
installed version is ensured to always be the latest available in the
registry. In addition, any semver expressions will also parse.