Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new constructor for WebAuthnProcessingFilter #1158

Conversation

TGITS
Copy link
Contributor

@TGITS TGITS commented Mar 9, 2023

A proposition to introduce a new constructor for WebAuthnProcessingFilter which allow to specify directly a UserVerificationStrategy instance without using the corresponding setter or relying on the Default value.

TGITS and others added 3 commits February 14, 2023 14:25
Synchronization with upstream project
Synchronization with upstream project
…lter which allow to specify directly a UserVerificationStrategy instance without using the corresponding setter on relying on the Default value.
@TGITS
Copy link
Contributor Author

TGITS commented Mar 10, 2023

The failed test does not seem to be related to the modification : the error seems to be related to a timeout running a selenium webdriver.
The test pass locally.
Is it possible to make the CI rerun this test ?

@ynojima ynojima merged commit 514f34e into webauthn4j:master Mar 11, 2023
@ynojima
Copy link
Member

ynojima commented Mar 11, 2023

Thank you for your pull-request! Merged.

@ynojima ynojima added the enhancement New feature or request label Mar 11, 2023
@ynojima ynojima added this to the 0.8.0.RELEASE milestone Mar 18, 2023
@ynojima ynojima changed the title Proposition to introduce a new constructor for WebAuthnProcessingFilter Introduce a new constructor for WebAuthnProcessingFilter Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants