Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

Commit

Permalink
Fix MAS invalid Bundle Identifier Electron Helper bug (#110)
Browse files Browse the repository at this point in the history
  • Loading branch information
quanglam2807 authored Dec 17, 2019
1 parent d1e6833 commit ee39618
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions patches/app-builder-lib+21.2.0.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/node_modules/app-builder-lib/out/electron/electronMac.js b/node_modules/app-builder-lib/out/electron/electronMac.js
index 8d9f9fc..14c1829 100644
--- a/node_modules/app-builder-lib/out/electron/electronMac.js
+++ b/node_modules/app-builder-lib/out/electron/electronMac.js
@@ -175,7 +175,7 @@ async function createMacApp(packager, appOutDir, asarIntegrity, isMas) {
function configureHelper(helper, postfix) {
helper.CFBundleExecutable = `${appFilename} Helper ${postfix}`;
helper.CFBundleDisplayName = `${appInfo.productName} Helper ${postfix}`;
- helper.CFBundleIdentifier = `${helperBundleIdentifier}.${postfix}`;
+ helper.CFBundleIdentifier = `${helperBundleIdentifier}.${postfix.replace(/[^a-z0-9]/gim, "")}`;
helper.CFBundleVersion = appPlist.CFBundleVersion;
}

0 comments on commit ee39618

Please sign in to comment.