Skip to content

Commit

Permalink
No issue. Fix new (post-rebase) test failures on refactor branch.
Browse files Browse the repository at this point in the history
  • Loading branch information
miketaylr committed Mar 23, 2018
1 parent c1816ae commit 4615a70
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 15 deletions.
2 changes: 1 addition & 1 deletion tests/functional/index-non-auth.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ registerSuite("Index", {
.findByCssSelector(".js-addon-link")
.getVisibleText()
.then(function(text) {
assert.include(text, "Download our");
assert.include(text, "Download");
})
.end();
},
Expand Down
10 changes: 4 additions & 6 deletions tests/functional/reporting-non-auth.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,8 @@ registerSuite("Reporting (non-auth)", {
)
.findByCssSelector("#url")
.click()
.type("sup")
.end()
.execute(function() {
var elm = document.querySelector("#url");
WindowHelpers.sendEvent(elm, "input");
})
.sleep(500)
.findByCssSelector(".form-message-error")
.getVisibleText()
Expand All @@ -92,7 +89,8 @@ registerSuite("Reporting (non-auth)", {
})
.end()
.findByCssSelector("#url")
.type("sup")
.clearValue()
.type("http://sup.com")
.end()
.waitForDeletedByCssSelector(".form-message-error")
.end();
Expand Down Expand Up @@ -160,7 +158,7 @@ registerSuite("Reporting (non-auth)", {
.execute(function() {
var elm = document.querySelector("#os");
elm.value = "";
WindowHelpers.sendEvent(elm, "input");
WindowHelpers.sendEvent(elm, "blur");
})
.end()
.sleep(500)
Expand Down
9 changes: 3 additions & 6 deletions tests/functional/search-non-auth.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ registerSuite("Search (non-auth)", {
)
.findByCssSelector("[data-remotename=browser-android]")
.click()
.sleep(2000)
.end()
.findDisplayedById("js-SearchForm-input")
.getProperty("value")
Expand Down Expand Up @@ -101,14 +102,10 @@ registerSuite("Search (non-auth)", {
.click()
.type("")
.type("\uE007")
.sleep(1000)
.sleep(3000)
.getCurrentUrl()
.then(function(currUrl) {
assert.notInclude(
currUrl,
"q=fffffff",
"old search param was removed"
);
assert.notInclude(currUrl, "fffffff", "old search param was removed");
})
.end();
}
Expand Down
2 changes: 1 addition & 1 deletion webcompat/templates/home-page/form.html
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ <h1 class="headline-1">Report Site Issue</h1>
</div>
<div class="form-text form-element js-Form-group">
{{ form.os(class_='form-field text-field') }}
<span class="form-input-validation check"></span>
<span class="form-input-validation check js-bug-form-os"></span>
</div>
<div class="form-radio form-element js-Form-group">
<div class="js-Form-information form-label-message">
Expand Down
2 changes: 1 addition & 1 deletion webcompat/templates/list-issue/issuelist-issue.jst
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<% } else { %>
<article class="grid-row">
<div class="grid-cell issue x3">
<h1 class="headline-1">Sorry, no results were found.</h1>
<h1 class="headline-1 js-no-results">Sorry, no results were found.</h1>
<p class="issue-labels js-Issue-label">
Please check your spelling or try a more general search. <br />
You can also search for popular labels like:
Expand Down

0 comments on commit 4615a70

Please sign in to comment.