Issue #855 - fixed broken test

webcompat · Dec 30, 2015 · df16b07 · df16b07
1 parent 5919a85
commit df16b07
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/tests/functional/contributors-non-auth.js b/tests/functional/contributors-non-auth.js
@@ -38,7 +38,7 @@ define([
           assert.notInclude('is-open', className);
         })
         .end()
-        .findByCssSelector('.wc-Hero-img').getAttribute('class')
+        .findByCssSelector('.wc-Hero-SVG').getAttribute('class')
         .then(function(className) {
           assert.notEqual('is-active', className);
         })
@@ -54,7 +54,7 @@ define([
           assert.equal(isDisplayed, true);
         })
         .end()
-        .findByCssSelector('.wc-Hero-img.is-active').isDisplayed()
+        .findByCssSelector('.wc-Hero-SVG.is-active').isDisplayed()
         .then(function(isDisplayed) {
           assert.equal(isDisplayed, true);
         })
@@ -66,7 +66,7 @@ define([
           assert.notInclude('is-open', className);
         })
         .end()
-        .findByCssSelector('.wc-Hero-img').getAttribute('class')
+        .findByCssSelector('.wc-Hero-SVG').getAttribute('class')
         .then(function(className) {
           assert.notInclude('is-active', className);
         });
@@ -76,14 +76,14 @@ define([
       return this.remote
         .setFindTimeout(intern.config.wc.pageLoadTimeout)
         .get(require.toUrl(url('/contributors')))
-        .findByCssSelector('.wc-Hero-img.is-active').isDisplayed()
+        .findByCssSelector('.wc-Hero-SVG.is-active').isDisplayed()
         .then(function(isDisplayed) {
           assert.equal(isDisplayed, true);
         })
         .end()
         .findByCssSelector('.contributors__item__title').click()
         .end()
-        .findByCssSelector('.wc-Hero-img').getAttribute('class')
+        .findByCssSelector('.wc-Hero-SVG').getAttribute('class')
         .then(function(className) {
           assert.notInclude('is-active', className);
         });

diff --git a/webcompat/static/css/development/components/hero.css b/webcompat/static/css/development/components/hero.css
@@ -123,11 +123,11 @@
     height:15em;
   }
 
-    .wc-Hero--contributors .wc-Hero-lightFilament {
+    /*.wc-Hero--contributors .wc-Hero-lightFilament {
       fill : #F0F0F0;
-    }
+    }*/
       /* is-active */
-      .wc-Hero-img.is-active .wc-Hero-lightFilament {
+      .wc-Hero-SVG.is-active .wc-Hero-lightFilament {
         fill: #E4BD0C;
       }
   @media (--viewport-600px) {

diff --git a/webcompat/templates/contributors.html b/webcompat/templates/contributors.html
@@ -10,7 +10,9 @@
           <h1 class="wc-Hero-title wc-Title--xl">Welcome aboard!<br/>Get started below...</h1>
         </div>
         <div class="wc-Hero-section wc-Hero-section--right">
-          {% include "shared/LightbulbwithBug.svg" %}
+          <div class="wc-Hero-SVG is-active">
+            {% include "shared/LightbulbwithBug.svg" %}
+          </div>
         </div>
       </div>
     </div>
@@ -79,7 +81,7 @@ <h2 id="contribute">
 {%- block extrascripts -%}
 <script>
 $(function(){
-  var lightElm     = $('.wc-Hero-img');
+  var lightElm     = $('.wc-Hero-SVG');
   var sections     = $('.contributors__item__content');
   var ACTIVE_CLASS = 'is-active';
   var OPEN_CLASS   = 'is-open';

diff --git a/webcompat/templates/shared/LightbulbwithBug.svg b/webcompat/templates/shared/LightbulbwithBug.svg