Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Green check mark not used on other form fields #1167

Closed
adamopenweb opened this issue Aug 30, 2016 · 6 comments
Closed

Green check mark not used on other form fields #1167

adamopenweb opened this issue Aug 30, 2016 · 6 comments

Comments

@adamopenweb
Copy link
Collaborator

When submitting a report on webcompat.com, there is a green check mark when the Site URL field is populated. The other fields do not have this, users could benefit from this consistency and error prevention.

@adamopenweb adamopenweb added this to the WebCompat Reporter UX Improvements milestone Aug 30, 2016
@magsout
Copy link
Member

magsout commented Sep 2, 2016

you're right, I need to make a better component for check mark. Mayebe with no SVG but only font icon..

@magsout magsout self-assigned this Sep 2, 2016
@karlcow
Copy link
Member

karlcow commented Sep 5, 2016

or simply one of ✓ ✅☑︎✔︎

@miketaylr
Copy link
Member

The other fields do not have this, users could benefit from this consistency and error prevention.

Right now there's only 2 required field: URL and problem type -- I guess it would be good to have some kind of checkmark for problem type? (The page autofills browser and OS... maybe a check would be good there, but we don't require them so I don't think an X makes sense.)

@miketaylr
Copy link
Member

(this issue is low priority, IMO. not a blocker)

@miketaylr
Copy link
Member

Or possibly, we just need to add the checkmark validation to the Browser / Version fields as well. That would make it more consistent and would be useful if people somehow deleted them (but they're not mandatory, so I guess just only care about the success case?).

@miketaylr miketaylr self-assigned this Oct 3, 2016
@miketaylr
Copy link
Member

Oh look, I said the same thing twice. Yay for consistency. 👀

miketaylr pushed a commit that referenced this issue Oct 4, 2016
miketaylr pushed a commit that referenced this issue Oct 4, 2016
It was kind of gross (added an error type to a collection of inputs).
miketaylr pushed a commit that referenced this issue Oct 5, 2016
miketaylr pushed a commit that referenced this issue Oct 6, 2016
deepthivenkat pushed a commit to deepthivenkat/webcompat.com that referenced this issue Oct 19, 2016
deepthivenkat pushed a commit to deepthivenkat/webcompat.com that referenced this issue Oct 19, 2016
deepthivenkat pushed a commit to deepthivenkat/webcompat.com that referenced this issue Oct 19, 2016
…image

It was kind of gross (added an error type to a collection of inputs).
deepthivenkat pushed a commit to deepthivenkat/webcompat.com that referenced this issue Oct 19, 2016
deepthivenkat pushed a commit to deepthivenkat/webcompat.com that referenced this issue Oct 19, 2016
deepthivenkat pushed a commit to deepthivenkat/webcompat.com that referenced this issue Oct 19, 2016
deepthivenkat pushed a commit to deepthivenkat/webcompat.com that referenced this issue Oct 19, 2016
deepthivenkat pushed a commit to deepthivenkat/webcompat.com that referenced this issue Oct 19, 2016
deepthivenkat pushed a commit to deepthivenkat/webcompat.com that referenced this issue Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants