Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement homepage mockup #128

Closed
miketaylr opened this issue May 20, 2014 · 8 comments · Fixed by #129
Closed

Implement homepage mockup #128

miketaylr opened this issue May 20, 2014 · 8 comments · Fixed by #129

Comments

@miketaylr
Copy link
Member

We can build this easily and deploy it before having 100% of /issues/ figured out, even if it just links to GitHub. I think it's a win to show sooner than later.

mockup

Working on this now.

@miketaylr
Copy link
Member Author

TODO:

  • Log in / log out header with github avatar
  • implement UI in HTML/CSS
  • Proxy open issues to some endpoint so we don't get murdered by API rate-limiting (and set up ember-model fixtures for development)
  • Display "needs diagnosis" and "ready for outreach" buckets
    • Create a "contactready" tag ("needs diagnosis" can probably just be ¬"contactready" (and not-closed)
    • Create "issue-state" computed property in the IndexController, use that to control CSS class
  • "Submitted by Me" logged in logic, see 8709fe2
  • "Load More" (this could come after, and we only display N results by default for now).

@calexity I see a "Closed" category here in the mockup, is the intention to only show this for "Submitted by Me"?

@miketaylr
Copy link
Member Author

I also want to add some more styles for the flash messages as part of this task,

gross is pretty ugly. I'm thinking we could position the message in the top bar over the "Give Feedback" and fade it away after N seconds.

@miketaylr
Copy link
Member Author

  • Restyle flash messages.

@miketaylr
Copy link
Member Author

After spending a few days on this (and thinking about it more over the weekend), I'm going to change strategy a little bit and do the following:

  1. ditch EmberJS for now, and render the homepage "Browse Issues" on the serverside. Adding ~1MB of JS for a couple of divs is sort of insane.
  2. Change Load More to See More, which will link to the GH repo for now.
  3. uh, get this done ASAP.

I plan on revisiting EmberJS when we build out the rest of Issues, for those who are sad now.

@miketaylr
Copy link
Member Author

Just pushed this live. \o/ Thanks again @calexity for the awesome design on this.

@calexity
Copy link
Contributor

Hey @miketaylr! Sorry for being so MIA. Yes, closed is only for issues you (as the user) submit. Looks great live! Thank you!

I couldn't tell if I missed a meeting yesterday am, but I'd like to identify a next sprint and place a goal date on it. I'm going to mark a couple issues and you guys can add feedback?

@miketaylr
Copy link
Member Author

Sounds great @calexity. There actually wasn't a meeting yesterday. :)

I was hoping to plan a few days to work out of the SF office in the next few weeks, maybe we could plan a jam session during the evening or something.

@calexity
Copy link
Contributor

Rock on! Would love that. Let me know when you'll be here and we'll make
it happen.

On Thu, May 29, 2014 at 9:00 AM, Mike Taylor notifications@github.com
wrote:

Sounds great @calexity https://github.com/calexity. There actually
wasn't a meeting yesterday. :)

I was hoping to plan a few days to work out of the SF office in the next
few weeks, maybe we could plan a jam session during the evening or
something.


Reply to this email directly or view it on GitHub
#128 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants