Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates.js tracked or not tracked. #1734

Closed
karlcow opened this issue Aug 30, 2017 · 5 comments
Closed

templates.js tracked or not tracked. #1734

karlcow opened this issue Aug 30, 2017 · 5 comments
Assignees

Comments

@karlcow
Copy link
Member

karlcow commented Aug 30, 2017

In #1730 I had a bit of troubles with this

This is tracked here:
https://github.com/webcompat/webcompat.com/blame/master/webcompat/static/js/templates.js

But

webcompat/static/js/templates.js

says to not track it…

Madness ensues with pre-commit.

@karlcow
Copy link
Member Author

karlcow commented Aug 30, 2017

This was added by this commit by @miketaylr
260c05b#diff-f5f2115c1d9da8f288334dd32f2cf1e4

@karlcow
Copy link
Member Author

karlcow commented Aug 30, 2017

@karlcow
Copy link
Member Author

karlcow commented Aug 30, 2017

→ git status
On branch master
Your branch is up-to-date with 'webcompat/master'.
nothing to commit, working directory clean

→ grunt
Running "checkDependencies:default" (checkDependencies) task

Running "jst:compile" (jst) task
File webcompat/static/js/templates.js created.

Running "concat:dist" (concat) task

Running "concat:diagnose" (concat) task

Running "concat:issues" (concat) task

Running "concat:issueList" (concat) task

Running "concat:userActivity" (concat) task

Running "concat:cssFixmeLibs" (concat) task

Running "uglify:dist" (uglify) task
>> 1 file created 545.13 kB → 386.68 kB

Running "uglify:issues" (uglify) task
>> 1 file created 41.36 kB → 23.64 kB

Running "uglify:issueList" (uglify) task
>> 1 file created 45.83 kB → 25.18 kB

Running "uglify:userActivity" (uglify) task
>> 1 file created 22.74 kB → 11.87 kB

Running "uglify:diagnose" (uglify) task
>> 1 file created 21.65 kB → 11.63 kB

Running "uglify:contributors" (uglify) task
>> 1 file created 1.05 kB → 737 B

Running "uglify:cssFixmeLibs" (uglify) task
>> 1 file created 131.46 kB → 63.7 kB

Running "postcss:dist" (postcss) task
>> 1 processed stylesheet created.

Running "cssmin:combine" (cssmin) task
>> 1 file created. 271.68 kB → 59.8 kB

Done.

@miketaylr
Copy link
Member

Yeah, that's a bug. It shouldn't be tracked...(but it's not the end of the world, just means you might be out of sync without realizing it).

miketaylr pushed a commit that referenced this issue Aug 30, 2017
It shouldn't be tracked (.gitignore was added after it was committed
to the repo (mistakenly)).
karlcow added a commit that referenced this issue Aug 30, 2017
Issue #1734. Remove templates.js
@miketaylr
Copy link
Member

Oops, forgot to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants