-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enter in description textbox submits form #1794
Comments
Yeah, that's crappy behavior, IMO. |
I just made the "Enter" mistake on webcompat/web-bugs#14683 Curious enough, the issue got submitted as Anonymus, despite the fact I was logged in. |
Ah, I know why. We rely on which button you've clicked (to allow logged in users to report things anonymously if they prefer). The current bug is sort of undefined behavior... |
Revert "Fixes #1794. Prevent form submission when pressing enter"
Let's put this webcompat/web-bugs#16299 for reference. |
Description is not a multiline field at all, it's just a normal single line input field. However it only triggers the form submit, when all required fields contain technically valid information. We could prevent the submit by hitting keyboard enter generally, which is from an accessibility point of view not ideal. Also it would require some extended event handling for keyboard events on the form in a whole. So there are multiple possible approaches to tackle this issue:
What do you think? @zoepage @miketaylr |
I think 1 is the least surprising. |
+1 on 1. :) |
Fixes #1794 - Prevent submit by enter in bugform
As described in this bug: webcompat/web-bugs#9706
If you press enter in the description textbox, it submits the form before you've (potentially) finished filling it out.
Maybe we should prevent this behaviour and force the user to click the button?
The text was updated successfully, but these errors were encountered: