Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jumping validation requirements #2074

Closed
miketaylr opened this issue Feb 15, 2018 · 5 comments
Closed

Jumping validation requirements #2074

miketaylr opened this issue Feb 15, 2018 · 5 comments

Comments

@miketaylr
Copy link
Member

STR:

  1. go to staging.webcompat.com/issues/new
  2. hit tab to cycle thru the form (or just click in and out of the URL and description inputs

Actual:
I get shown a "A valid URL is required.", etc. which causes the layout to jump down.

Expected:
Can we figure out how to do this without shifting layout?

Also, when you put something in, those messages don't disappear. Not sure if that is intended behavior.

@zoepage
Copy link
Member

zoepage commented Feb 19, 2018

Also, when you put something in, those messages don't disappear. Not sure if that is intended behavior.

This is definitely a bug that needs to be fixed.

Can we figure out how to do this without shifting layout?

Definitely. Do you feel this has a high prio or could be split the two issues?

@zoepage
Copy link
Member

zoepage commented Feb 20, 2018

Also, when you put something in, those messages don't disappear. Not sure if that is intended behavior.

This is related to #2149 and will be fixed with that issue.

@miketaylr
Copy link
Member Author

Definitely. Do you feel this has a high prio or could be split the two issues?

Splitting seems fine!

@zoepage
Copy link
Member

zoepage commented Feb 28, 2018

@miketaylr FYI #2149 is fixed. We just need to fix the jumping issue now.

zoepage added a commit that referenced this issue Feb 28, 2018
miketaylr pushed a commit that referenced this issue Feb 28, 2018
Fixes #2074 - fix jumping error message
@zoepage
Copy link
Member

zoepage commented Feb 28, 2018

merged #2197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants