Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get tests green on refactor branch #2106

Closed
miketaylr opened this issue Feb 16, 2018 · 3 comments
Closed

Get tests green on refactor branch #2106

miketaylr opened this issue Feb 16, 2018 · 3 comments
Assignees
@miketaylr
Labels
type: bug type: testing
Milestone
January / Februar...

Comments

@miketaylr
Copy link
Member

Once this is done, no more PRs into refactor will be allowed without fixing broken tests.
@miketaylr
Copy link
Member Author

miketaylr commented Feb 16, 2018 •
edited
Loading

  • Comments (auth)
  • Contributors
  • History navigation
  • Image Uploads (non-auth)
  • Index - front page loads
  • Issue-list
  • Issues (auth)
  • Issues
  • Labels (auth)
  • Milestones (auth)
  • Milestones (non-auth)
  • New Issue Page
  • Reporting (auth)
  • Reporting (non-auth)
  • Search (auth)
  • Search (non-auth)
  • User Activity (auth)
  • User Activity (non-auth)

@miketaylr
Copy link
Member Author

82f1e7f

This was referenced Feb 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Merged
miketaylr added a commit that referenced this issue Feb 16, 2018
@miketaylr
Fixes #2117. Fix milestones auth tests.
0563bc4 
cf. #2106
This was referenced Feb 16, 2018
Merged
Closed
Closed
Closed
Closed
Closed
Closed
@magsout magsout mentioned this issue Feb 16, 2018
Merged
This was referenced Feb 17, 2018
Merged
Merged
@miketaylr miketaylr self-assigned this Feb 17, 2018
This was referenced Feb 17, 2018
Merged
Merged
@miketaylr miketaylr mentioned this issue Feb 20, 2018
Closed
zoepage added a commit that referenced this issue Feb 22, 2018
@zoepage
Merge pull request #2187 from /issues/2110/4
c7e257c 
Fixes #2110, #2106: Get the rest of the tests passing.
@miketaylr
Copy link
Member Author

OK, this is done. But possibly the tests are flaky now. Please file follow up bugs for those tests, if anyone runs into them locally.

miketaylr added a commit that referenced this issue Mar 23, 2018
@miketaylr
Fixes #2117. Fix milestones auth tests.
e5add90 
cf. #2106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
type: bug type: testing
Projects
None yet
Milestone
January / February / March 2018
Development

No branches or pull requests
2 participants
@miketaylr @zoepage