Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout becomes messed up after reporting an issue #2155

Closed
softvision-oana-arbuzov opened this issue Feb 19, 2018 · 2 comments
Closed

Layout becomes messed up after reporting an issue #2155

softvision-oana-arbuzov opened this issue Feb 19, 2018 · 2 comments

Comments

@softvision-oana-arbuzov
Copy link
Member

softvision-oana-arbuzov commented Feb 19, 2018

URL: https://staging.webcompat.com/
Browser / Version: Firefox Nightly Mobile 60.0a1 (2018-02-18), Firefox Nightly Desktop 60.0a1 (2018-02-16), Chrome Desktop 64.0.3282.167, Chrome Mobile 64.0.3282.137
Operating System: Windows 10 Pro, Google Pixel (Android 8.0.0) - 1080 x 1920 pixels (~441 ppi pixel density)

Steps to Reproduce:

  1. Navigate to https://staging.webcompat.com/
  2. Tap "Report bug" button.
  3. Type in all required information.
  4. Tap "Report" button (anonymous of with the Github account).
  5. Observe behavior after issue is logged successfully.

Expected Behavior:
An overlay with "Thanks" message is displayed and dismissed for after a few seconds.
"Share on Twitter"/"Share on Facebook" button are displayed under the reported issue.

Actual Behavior:
"Thanks for reporting an issue!" message overlaps the bug report.

Note

  1. Workaround: Refreshing the screen, the "Thanks" message is dismissed.
  2. "Thanks" message:
<div class="notification-bar js-flashmessage is-active notification-thanks">
	<h4>Thanks for reporting an issue!</h4>
	<p>You're helping us make the web a better place to work and play.</p>
	<p>Tell your friends about the bug you just filed:</p>
	<a class="wc-Button wc-Button--action" href="https://twitter.com/intent/tweet?text=I%20just%20filed%20a%20bug%20on%20the%20internet%3A&amp;url=https%3A%2F%2Fwebcompat.com%2Fissues%2F1376&amp;via=webcompat" target="_blank">Share on Twitter</a>
	<a class="wc-Button wc-Button--action" href="https://facebook.com/sharer/sharer.php?u=https%3A%2F%2Fwebcompat.com%2Fissues%2F1376" target="_blank">Share on Facebook</a>
</div>

Watchers:
@softvision-sergiulogigan
@softvision-oana-arbuzov

screenshot-1519044666800

thanksmessageoverbugreport

@zoepage
Copy link
Member

zoepage commented Feb 19, 2018

thanks.jst is not refactored yet. This is what is causing this issue.

@miketaylr miketaylr self-assigned this Mar 15, 2018
miketaylr added a commit that referenced this issue Mar 16, 2018
Otherwise, the thanks notification will be too tiny.
zoepage pushed a commit that referenced this issue Mar 20, 2018
Otherwise, the thanks notification will be too tiny.
zoepage added a commit that referenced this issue Mar 20, 2018
zoepage added a commit that referenced this issue Mar 21, 2018
zoepage added a commit that referenced this issue Mar 21, 2018
Fixes #2155 - add thanks.jst msg
@zoepage
Copy link
Member

zoepage commented Mar 21, 2018

merged #2278

@zoepage zoepage closed this as completed Mar 21, 2018
miketaylr pushed a commit that referenced this issue Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants