Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hero image on non-desktop #2205

Closed
zoepage opened this issue Mar 6, 2018 · 2 comments
Closed

Hero image on non-desktop #2205

zoepage opened this issue Mar 6, 2018 · 2 comments
Assignees
@zoepage
Milestone
January / Februar...

Comments

@zoepage
Copy link
Member

zoepage commented Mar 6, 2018

screen shot 2018-03-06 at 2 27 35 pm

I was pretty sure this was reported already, but couldn't find it.
@zoepage zoepage self-assigned this Mar 6, 2018
@zoepage
Copy link
Member Author

zoepage commented Mar 13, 2018

@Regaddi would this be something you'd be interested in?

Regaddi pushed a commit that referenced this issue Mar 14, 2018
Fixes #2205. Refined margin and padding definitions for body and hero
f0fd3a2
Regaddi pushed a commit that referenced this issue Mar 14, 2018
Fixes #2205. Let hero expand to edges in mobile & tablet viewports
7ef239e
Regaddi pushed a commit that referenced this issue Mar 14, 2018
Fixes #2205. Introduced new css variables for grid edges
5d4fe5b
zoepage added a commit that referenced this issue Mar 14, 2018
@zoepage
Merge pull request #2235 from /issues/2205
a7064a0 
WIP: Fixes #2205 – Refine margins and paddings around hero element
@zoepage
Copy link
Member Author

zoepage commented Mar 14, 2018

merged in #2235

@zoepage zoepage closed this as completed Mar 14, 2018
miketaylr pushed a commit that referenced this issue Mar 23, 2018
@miketaylr
Fixes #2205. Refined margin and padding definitions for body and hero
e192c54
miketaylr pushed a commit that referenced this issue Mar 23, 2018
@miketaylr
Fixes #2205. Let hero expand to edges in mobile & tablet viewports
c276275
miketaylr pushed a commit that referenced this issue Mar 23, 2018
@miketaylr
Fixes #2205. Introduced new css variables for grid edges
56a7014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoepage zoepage

Labels
None yet
Projects
None yet
Milestone
January / February / March 2018
Development

No branches or pull requests
1 participant
@zoepage