Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Download our Chrome Extension" – Text wraps below icon #2224

Closed
Regaddi opened this issue Mar 13, 2018 · 3 comments
Closed

"Download our Chrome Extension" – Text wraps below icon #2224

Regaddi opened this issue Mar 13, 2018 · 3 comments

Comments

@Regaddi
Copy link
Member

Regaddi commented Mar 13, 2018

Description:
In smaller viewports, when the header bar has not enough space, the text "Download our Chrome Extension" is wrapped below the download icon.

Browser:
Chrome Version 65.0.3325.146
macOS High Sierra 10.13.3

Suggested fix:
Add white-space: nowrap; to the element nav-link js-addon-link.

Additional comment:
If you don't mind, I'll submit a PR in a minute to fix this.

Screenshot:
image

Watchers:
@zoepage

@Regaddi
Copy link
Member Author

Regaddi commented Mar 13, 2018

Nevertheless, when the user is not logged in, a link drops to the next line on 665px viewport width:

image

Also on Firefox:

image

This might be another issue...

@zoepage
Copy link
Member

zoepage commented Mar 13, 2018

This is probably related to #2164

zoepage added a commit that referenced this issue Mar 14, 2018
zoepage added a commit that referenced this issue Mar 14, 2018
zoepage added a commit that referenced this issue Mar 14, 2018
zoepage added a commit that referenced this issue Mar 14, 2018
@zoepage
Copy link
Member

zoepage commented Mar 14, 2018

merged #2233

@zoepage zoepage closed this as completed Mar 14, 2018
miketaylr pushed a commit that referenced this issue Mar 23, 2018
miketaylr pushed a commit that referenced this issue Mar 23, 2018
miketaylr pushed a commit that referenced this issue Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants