Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty search submit shows "undefined" in search bar #2234

Closed
Regaddi opened this issue Mar 14, 2018 · 2 comments
Closed

Empty search submit shows "undefined" in search bar #2234

Regaddi opened this issue Mar 14, 2018 · 2 comments
Labels
prio: important type: bug
Milestone
January / Februar...

Comments

@Regaddi
Copy link
Member

Regaddi commented Mar 14, 2018

Steps to reproduce:

  1. Go to https://staging.webcompat.com
  2. Click on "Search"
  3. Leave input empty and hit enter
  4. Searchbar on issue navigator contains "undefined"

bildschirmfoto 2018-03-14 um 14 08 04
@zoepage
Copy link
Member

zoepage commented Mar 14, 2018

YES! You could reproduce! Nice :D
(I ran into that issue, but could not reproduce.)

zoepage added a commit that referenced this issue Mar 14, 2018
@zoepage
Issue #2234 - empty search returns undefined
089f10a
@Regaddi Regaddi mentioned this issue Mar 15, 2018
Merged
Regaddi pushed a commit that referenced this issue Mar 20, 2018
Fixes #2234 - Adjust regex for search param. Prevent empty topbar sea…
c6cb4c1 
…rch submit
miketaylr pushed a commit that referenced this issue Mar 22, 2018
Merge pull request #2237 from /issues/2234
694e303 
Fixes #2234 - empty search returns undefined
miketaylr pushed a commit that referenced this issue Mar 23, 2018
@zoepage @miketaylr
Issue #2234 - empty search returns undefined
e0ccdd0
miketaylr pushed a commit that referenced this issue Mar 23, 2018
@miketaylr
Fixes #2234 - Adjust regex for search param. Prevent empty topbar sea…
4a4b1d2 
…rch submit
@zoepage
Copy link
Member

zoepage commented Mar 28, 2018

didn't we fix this a few days ago? 🤔
yes, with #2237

@zoepage zoepage closed this as completed Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio: important type: bug
Projects
None yet
Milestone
January / February / March 2018
Development

No branches or pull requests
2 participants
@zoepage @Regaddi