Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue detail page grid off #2247

Closed
Regaddi opened this issue Mar 16, 2018 · 3 comments
Closed

Issue detail page grid off #2247

Regaddi opened this issue Mar 16, 2018 · 3 comments

Comments

@Regaddi
Copy link
Member

Regaddi commented Mar 16, 2018 •
edited
Loading

The issue detail page got a little bit off after solving #2245.

image

I'd suggest the following layout as a fix (got everything ready locally):

image

@zoepage ?
@zoepage
Copy link
Member

zoepage commented Mar 16, 2018

@Regaddi +1

Regaddi pushed a commit that referenced this issue Mar 16, 2018
Fixes #2247. Corrected grid-nested.
39fc925
zoepage added a commit that referenced this issue Mar 16, 2018
@zoepage
Merge pull request #2251 from /issues/2247
2fe8cca 
Fixes #2247. Corrected grid-nested.
@zoepage
Copy link
Member

zoepage commented Mar 16, 2018

merged #2251

@zoepage zoepage closed this as completed Mar 16, 2018
@zoepage zoepage reopened this Mar 16, 2018
@zoepage
Copy link
Member

zoepage commented Mar 16, 2018

Comments and Uploads are missing a grid-nested class. Just as a quick addition.

@Regaddi Regaddi mentioned this issue Mar 18, 2018
Merged
zoepage added a commit that referenced this issue Mar 19, 2018
@zoepage
Merge pull request #2252 from /issues/2247
7023228 
Fixes #2247 -  nested grid in issue details.
@zoepage zoepage closed this as completed Mar 19, 2018
miketaylr pushed a commit that referenced this issue Mar 23, 2018
@miketaylr
Fixes #2247. Corrected grid-nested.
5c563fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zoepage @Regaddi