Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons are not displayed on Safari (Mobile + Desktop) #2255

Closed
magsout opened this issue Mar 16, 2018 · 7 comments
Closed

Icons are not displayed on Safari (Mobile + Desktop) #2255

magsout opened this issue Mar 16, 2018 · 7 comments
Assignees
@zoepage
Labels
prio: important type: bug
Milestone
January / Februar...

Comments

@magsout
Copy link
Member

magsout commented Mar 16, 2018 •
edited
Loading

Hmm, I already opened a problem about this bug? I think it's something about CSP , no?

On iOS with Firefox and Safari, the icons are not displayed

img_0441
@magsout magsout changed the title No icon is displayed on iOS Icons are not displayed on iOS Mar 16, 2018
@magsout
Copy link
Member Author

magsout commented Mar 16, 2018

found it #1647

@zoepage
Copy link
Member

zoepage commented Mar 17, 2018

Interesting... @miketaylr did you see that already before? Like is this a known issue?

@miketaylr
Copy link
Member

Interesting... @miketaylr did you see that already before? Like is this a known issue?

@zoepage I think this is a new bug (at least, not previously reported). Probably P0?

@miketaylr
Copy link
Member

Not just iOS, Safari as well:

screen shot 2018-03-19 at 2 26 43 pm

@miketaylr miketaylr changed the title Icons are not displayed on iOS Icons are not displayed on Safari (Mobile + Desktop) Mar 19, 2018
@miketaylr
Copy link
Member

https://stackoverflow.com/a/43962207

@miketaylr
Copy link
Member

Using xlink:href instead of href will fix this issue, @zoepage.

screen shot 2018-03-19 at 2 39 12 pm

screen shot 2018-03-19 at 2 40 33 pm

@miketaylr miketaylr assigned miketaylr and zoepage and unassigned miketaylr Mar 19, 2018
@magsout
Copy link
Member Author

magsout commented Mar 19, 2018

@miketaylr oh good catch.

Regaddi pushed a commit that referenced this issue Mar 20, 2018
Fixes #2255 - Use xlink:href attribute for SVG references
87ddd69
Regaddi pushed a commit that referenced this issue Mar 20, 2018
Fixes #2255 - Fix SVG references in JST templates
d79ea96
Regaddi pushed a commit that referenced this issue Mar 20, 2018
Fixes #2255 - Fix SVG references in JST templates
3120ce0
miketaylr pushed a commit that referenced this issue Mar 20, 2018
Merge pull request #2266 from /issues/2255
a3300c6 
Fixes #2255 - Use xlink:href attribute for SVG references
@magsout magsout closed this as completed Mar 20, 2018
miketaylr pushed a commit that referenced this issue Mar 23, 2018
@miketaylr
Fixes #2255 - Use xlink:href attribute for SVG references
fdb8857
miketaylr pushed a commit that referenced this issue Mar 23, 2018
@miketaylr
Fixes #2255 - Fix SVG references in JST templates
7142785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoepage zoepage

Labels
prio: important type: bug
Projects
None yet
Milestone
January / February / March 2018
Development

No branches or pull requests
3 participants
@miketaylr @zoepage @magsout