Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

milestone labels list has wrong colored borders #2277

Closed
zoepage opened this issue Mar 21, 2018 · 2 comments
Closed

milestone labels list has wrong colored borders #2277

zoepage opened this issue Mar 21, 2018 · 2 comments
Labels
prio: good next bug type: bug

Comments

@zoepage
Copy link
Member

zoepage commented Mar 21, 2018

The border-left should indicate the color of the status, but here it jumps back to default as it's been overwritten per CSS. We need to adjust the specificity.

Labels (should):
screen shot 2018-03-21 at 11 27 33 am

Milestones (default, but wrong):
screen shot 2018-03-21 at 11 27 24 am

Code can be found here:
https://github.com/webcompat/webcompat.com/blob/refactor/webcompat/static/css/src/labels.css#L69-L97
@zoepage
Copy link
Member Author

zoepage commented Mar 21, 2018

@Regaddi Interested? :)

Regaddi pushed a commit that referenced this issue Mar 21, 2018
Fixes #2277 - Add missing border colors for status labels
cc72003
zoepage added a commit that referenced this issue Mar 22, 2018
@zoepage
Merge pull request #2279 from /issues/2277
b52a1bd 
Fixes #2277 - Add missing border colors for status labels
@zoepage
Copy link
Member Author

zoepage commented Mar 22, 2018

merged #2279

@zoepage zoepage closed this as completed Mar 22, 2018
miketaylr pushed a commit that referenced this issue Mar 23, 2018
@miketaylr
Fixes #2277 - Add missing border colors for status labels
18ccec6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio: good next bug type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zoepage