Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change .navigation to .js-navigation in homepage.js #2324

Closed
zoepage opened this issue Mar 28, 2018 · 1 comment
Closed

Change .navigation to .js-navigation in homepage.js #2324

zoepage opened this issue Mar 28, 2018 · 1 comment
Assignees
@zoepage

Comments

@zoepage
Copy link
Member

zoepage commented Mar 28, 2018

To make sure we separate css and js classes, lets add .js-navigation to homepage.js and the html files.
@zoepage zoepage self-assigned this Mar 28, 2018
zoepage added a commit that referenced this issue Mar 28, 2018
@zoepage
Issue #2324 - add js class to separate css and js functionality
43d1e29
miketaylr pushed a commit that referenced this issue Mar 28, 2018
Merge pull request #2325 from /issues/2324
101e20c 
Fixes #2324 - add js class to separate css and js functionality
@zoepage
Copy link
Member Author

zoepage commented Mar 28, 2018

merged #2325

@zoepage zoepage closed this as completed Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoepage zoepage

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zoepage