Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging capabilities to Flask #245

Closed
karlcow opened this issue Aug 29, 2014 · 6 comments
Closed

Add logging capabilities to Flask #245

karlcow opened this issue Aug 29, 2014 · 6 comments

Comments

@karlcow
Copy link
Member

karlcow commented Aug 29, 2014

It would be good to have logging capabilities for the different calls of the program, that would help us have a better understanding on where we do wrong things and where to solve redundancies.

@miketaylr
Copy link
Member

+1. I've used http://flask-debugtoolbar.readthedocs.org/en/latest/ locally for logging purposes -- you can do something like https://github.com/mgood/flask-debugtoolbar/blob/master/example/example.py#L33 and the toolbar will show the logs.

But having some "real" logging to file would be a great contribution.

@karlcow
Copy link
Member Author

karlcow commented Sep 10, 2015

Things to log. Missmatch with the DB.

If you delete Session.db and restart the app, the database will be created with the correct columns. I'll add something to CONTRIBUTING.md about this error so people can find it in the future.

see discussion in #700

@karlcow
Copy link
Member Author

karlcow commented Sep 10, 2015

Things to log. User login error.

@karlcow karlcow self-assigned this Sep 14, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Sep 14, 2015
@karlcow
Copy link
Member Author

karlcow commented Sep 14, 2015

I would recommend we create a file that we rotate once a day, and that we send automatically by email with a cron. This to avoid to have a dependency on queuing jobs inside flask. Also we currently have no need for live debugging info. We can revisit this a bit later.

The log file can be sent to a couple of persons maybe @miketaylr and myself.

@karlcow
Copy link
Member Author

karlcow commented Sep 15, 2015

in #704 @miketaylr said:

+1, thanks @karlcow. Before we log anything that might be privacy-sensitive, let's be sure to update our privacy document. And maybe adding a few notes on usage to CONTRIBUTING.md would be a good addition as well.

Opened #705 and #706 for this purpose.

@miketaylr
Copy link
Member

Thanks Karl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants