-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding engine-gecko
label for Firefox browsers?
#2856
Comments
Would this be intended to include Gecko browsers like Waterfox (for the rare report we get in that regard), or just the Mozilla releases? |
I thought about this, and I'm not 100% sure. If it's about UA sniffing, probably not. But bugs that stem from core Gecko platform differences would be good to capture. |
The concept sounds good to me. My belief is that labels should be honest about what they represent, so a Alternatively, existing labels seem to have a kind of hierarchical naming, e.g. |
are the 3 main engines which still exist. Maybe a bit of engine-presto for Opera Mini, but I'm not even sure. The most difficult part is how to identify them, because they usually don't advertise themselves. I'm interested to understand the false positives we would get with this system. |
Yeah, identifying them wouldn't be perfect. We could just create some kind of mapping of known browser-products <-> browser-engines and update it as we went along. Or, not bother with the other engines until someone has a use-case for the data. :p |
I think I'm gonna go with that. It won't be perfect, but we can improve it in the future. |
engine-gecko
label for Firefox browsers?engine-gecko
label for Firefox browsers?
(thanks for the input everyone) |
btw is the goal to just select firefox. |
@miketaylr Also… we can't do indeed I'm using that for diagnosis list and to know if there is a lot to do. :) |
Co-Authored-By: miketaylr <miket@mozilla.com>
A proposal -- curious about other people's input here.
I would like us to add a label -- the exact wording doesn't matter to me -- that captures that the browser is a Mozilla-produced product running on Gecko.
The use case is I want to track all issues on webcompat.com that affect Gecko-based Firefox browsers.
Currently, GitHub search doesn't allow logical OR searches.
So instead of having something like
... label:browser-firefox OR label:firefox-mobile..
, etc., I need to do 6 queries. In addition to firefox and firefox-mobile, we also havebrowser-focus-geckoview
andbrowser-geckoview
andbrowser-firefox-reality
, andbrowser-fenix
.Thoughts? @karlcow @adamopenweb @webcompat/core-developers ?
The text was updated successfully, but these errors were encountered: