Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding engine-gecko label for Firefox browsers? #2856

Closed
miketaylr opened this issue Apr 26, 2019 · 10 comments
Closed

Consider adding engine-gecko label for Firefox browsers? #2856

miketaylr opened this issue Apr 26, 2019 · 10 comments
Assignees

Comments

@miketaylr
Copy link
Member

A proposal -- curious about other people's input here.

I would like us to add a label -- the exact wording doesn't matter to me -- that captures that the browser is a Mozilla-produced product running on Gecko.

The use case is I want to track all issues on webcompat.com that affect Gecko-based Firefox browsers.

Currently, GitHub search doesn't allow logical OR searches.

So instead of having something like ... label:browser-firefox OR label:firefox-mobile.., etc., I need to do 6 queries. In addition to firefox and firefox-mobile, we also have browser-focus-geckoview and browser-geckoview and browser-firefox-reality, and browser-fenix.

Thoughts? @karlcow @adamopenweb @webcompat/core-developers ?

@wisniewskit
Copy link
Member

Would this be intended to include Gecko browsers like Waterfox (for the rare report we get in that regard), or just the Mozilla releases?

@miketaylr
Copy link
Member Author

Would this be intended to include Gecko browsers like Waterfox (for the rare report we get in that regard), or just the Mozilla releases?

I thought about this, and I'm not 100% sure. If it's about UA sniffing, probably not. But bugs that stem from core Gecko platform differences would be good to capture.

@tagawa
Copy link
Member

tagawa commented Apr 29, 2019

The concept sounds good to me. My belief is that labels should be honest about what they represent, so a browser-gecko label would include all Gecko browsers, e.g. Waterfox. If it's just for Mozilla browsers then browser-mozilla seems a better label IMO.

Alternatively, existing labels seem to have a kind of hierarchical naming, e.g. browser-firefox and browser-firefox-mobile, so if it's for Mozilla-only Gecko browsers then how about browser-mozilla-gecko or browser-gecko-mozilla?

@karlcow
Copy link
Member

karlcow commented Apr 29, 2019

Alternatively, existing labels seem to have a kind of hierarchical naming

There's a plan to get away from this 🤣 but I didn't get the time to punch it through.
see #997 and #2531

@karlcow
Copy link
Member

karlcow commented Apr 29, 2019

  • engine-gecko
  • engine-blink
  • engine-webkit

are the 3 main engines which still exist.

Maybe a bit of engine-presto for Opera Mini, but I'm not even sure.

The most difficult part is how to identify them, because they usually don't advertise themselves.
A google example is Firefox Focus on Android which has both a webkit and a geckoview.

I'm interested to understand the false positives we would get with this system.

@miketaylr
Copy link
Member Author

Yeah, identifying them wouldn't be perfect.

We could just create some kind of mapping of known browser-products <-> browser-engines and update it as we went along. Or, not bother with the other engines until someone has a use-case for the data. :p

@miketaylr
Copy link
Member Author

We could just create some kind of mapping of known browser-products <-> browser-engines and update it as we went along

I think I'm gonna go with that. It won't be perfect, but we can improve it in the future.

@miketaylr miketaylr self-assigned this Apr 29, 2019
@miketaylr miketaylr changed the title [discussion] Consider adding engine-gecko label for Firefox browsers? Consider adding engine-gecko label for Firefox browsers? Apr 29, 2019
@miketaylr
Copy link
Member Author

(thanks for the input everyone)

@karlcow
Copy link
Member

karlcow commented Apr 30, 2019

So instead of having something like ... label:browser-firefox OR label:firefox-mobile.., etc., I need to do 6 queries. In addition to firefox and firefox-mobile, we also have browser-focus-geckoview and browser-geckoview and browser-firefox-reality, and browser-fenix.

btw is the goal to just select firefox.
Then the move in #2531 is supposed to solve that.

@karlcow
Copy link
Member

karlcow commented Apr 30, 2019

@miketaylr Also… we can't do indeed OR, but we can do negative AND.

I'm using that for diagnosis list and to know if there is a lot to do. :)
For example
is:issue milestone:needsdiagnosis sort:comments-asc -label:browser-chrome -label:browser-chrome-mobile -label:browser-safari -label:browser-samsung -label:browser-mobile-safari is:open

miketaylr pushed a commit that referenced this issue Apr 30, 2019
Co-Authored-By: miketaylr <miket@mozilla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants