Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking label on /issues when not logged in shows flash error #345

Closed
miketaylr opened this issue Nov 6, 2014 · 2 comments
Closed

Clicking label on /issues when not logged in shows flash error #345

miketaylr opened this issue Nov 6, 2014 · 2 comments
Labels
status: needs tests type: bug

Comments

@miketaylr
Copy link
Member

Oops.

Works as expected when logged in --fallout from making search logged in only (clicking a label updates the search input). The fix should be to just do that in the background.
@miketaylr miketaylr mentioned this issue Nov 7, 2014
Closed
miketaylr pushed a commit that referenced this issue Nov 7, 2014
Issue #345 - add _isLoggedIn private property to IssueView
e95c146 
Also rename for MainView.
miketaylr pushed a commit that referenced this issue Nov 7, 2014
Issue #345 - update search input when logged in, when clicking label
1866cd2
@magsout
Copy link
Member

magsout commented Nov 7, 2014

Fix, good job @miketaylr

@magsout magsout closed this as completed Nov 7, 2014
@miketaylr
Copy link
Member Author

\o/. Thanks for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs tests type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @magsout