Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS fixes related to a11y changes #390

Closed
2 tasks done
miketaylr opened this issue Nov 13, 2014 · 10 comments
Closed
2 tasks done

CSS fixes related to a11y changes #390

miketaylr opened this issue Nov 13, 2014 · 10 comments
Assignees
@miketaylr
Labels
type: site-development

Comments

@miketaylr
Copy link
Member

To track the remaining work that needs to happen on the staging branch before we can pull in #363.
@miketaylr miketaylr mentioned this issue Nov 13, 2014
Closed
@magsout magsout self-assigned this Nov 15, 2014
@miketaylr
Copy link
Member Author

@magsout can I help with this? (even tho I'm a noob)

@magsout
Copy link
Member

magsout commented Dec 5, 2014

yeeaah

@miketaylr
Copy link
Member Author

Hey @andrewmcgivery -- I'll try to find some time for this early next week unless you beat me to it.

@miketaylr miketaylr assigned miketaylr and unassigned magsout Dec 6, 2014
@miketaylr
Copy link
Member Author

I just rebased the staging branch (which has the a11y PR changeset) against master and fixed a merge conflict (just a simple update to the privacy page) and pushed to staging.

miketaylr pushed a commit that referenced this issue Dec 6, 2014
Issue #390 - Issue title too big.
066eec2
miketaylr pushed a commit that referenced this issue Dec 6, 2014
Issue #390 - Make Issues page title smaller
87c739b
@miketaylr
Copy link
Member Author

Hmm, looking at - [ ] Privacy policy headers too big (http://staging.webcompat.com/privacy), it looks OK to me. Maybe this is done?

@miketaylr
Copy link
Member Author

Just need to fix failing tests from markup changes. Almost there.

@andrewmcgivery
Copy link
Contributor

Exciting! :)

@magsout
Copy link
Member

magsout commented Dec 8, 2014

@miketaylr just pushed 1c9d6f7 and e8f8817

miketaylr pushed a commit that referenced this issue Dec 8, 2014
Merge branch 'js-features' of https://github.com/tagawa/webcompat.com …
c515b17 
…into tagawa-js-features

* 'js-features' of https://github.com/tagawa/webcompat.com:
  Enabled 'g' key to open GitHub issues page
  Enabled 'g' key to open GitHub issues page
  Issue #363 - Fix tests to account for now markup.
  Issue #390 - Make Issues page title smaller
  Issue #390 - Issue title too big.
  Another Tab -> Space
  Accessibility Fixes
miketaylr pushed a commit that referenced this issue Dec 8, 2014
Merge branch 'tagawa-js-features'
ffc1919 
* tagawa-js-features:
  Enabled 'g' key to open GitHub issues page
  Enabled 'g' key to open GitHub issues page
  Issue #363 - Fix tests to account for now markup.
  Issue #390 - Make Issues page title smaller
  Issue #390 - Issue title too big.
  Another Tab -> Space
  Accessibility Fixes
@miketaylr
Copy link
Member Author

@magsout much nicer. :D you rock. 💃

@miketaylr
Copy link
Member Author

OK, this is fixed now. One small tweak to the 404 page that I'll just push to master and we can deploy.

miketaylr pushed a commit that referenced this issue Dec 8, 2014
Issue #390 - Add title classes to 404 page.
93cb165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
type: site-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@miketaylr @magsout @andrewmcgivery