Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a python generic function for handling Link header parsing #451

Closed
karlcow opened this issue Dec 5, 2014 · 3 comments
Closed

Add a python generic function for handling Link header parsing #451

karlcow opened this issue Dec 5, 2014 · 3 comments

Comments

@karlcow
Copy link
Member

karlcow commented Dec 5, 2014

We probably need to parse links in a few use cases for rewriting and/or sanitizing them. We have already two places we are doing that. Time for a refactoring.

See

def sanitize_link(link_header):

and
def rewrite_links(link_header):

karlcow added a commit to karlcow/webcompat.com that referenced this issue Jan 29, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jan 29, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jan 29, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jan 29, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jan 29, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jan 29, 2015
@karlcow
Copy link
Member Author

karlcow commented Jan 29, 2015

Some more complex libraries and more generic than ours.

But I think I will stick to something custom made. Experimenting and addting tests.

karlcow added a commit to karlcow/webcompat.com that referenced this issue Feb 3, 2015
@karlcow
Copy link
Member Author

karlcow commented Feb 3, 2015

Probably should use a map(our_func, iterable_links_list)

karlcow added a commit to karlcow/webcompat.com that referenced this issue Feb 4, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Feb 4, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Feb 4, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Feb 4, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Feb 4, 2015
@karlcow
Copy link
Member Author

karlcow commented Feb 4, 2015

→ nosetests
................
----------------------------------------------------------------------
Ran 16 tests in 0.395s

OK

pfew

@karlcow karlcow closed this as completed in e1304a3 Feb 4, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Feb 5, 2015
karlcow added a commit to karlcow/webcompat.com that referenced this issue Feb 5, 2015
karlcow added a commit that referenced this issue Feb 28, 2015
karlcow added a commit that referenced this issue Feb 28, 2015
karlcow added a commit that referenced this issue Feb 28, 2015
karlcow added a commit that referenced this issue Feb 28, 2015
karlcow added a commit that referenced this issue Feb 28, 2015
karlcow added a commit that referenced this issue Feb 28, 2015
karlcow added a commit that referenced this issue Feb 28, 2015
karlcow added a commit that referenced this issue Feb 28, 2015
karlcow added a commit that referenced this issue Feb 28, 2015
karlcow added a commit that referenced this issue Feb 28, 2015
karlcow added a commit that referenced this issue Feb 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant