Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that editLabels converts between namespace and non-namespace #658

Closed
miketaylr opened this issue Aug 4, 2015 · 1 comment
Closed

Make sure that editLabels converts between namespace and non-namespace #658

miketaylr opened this issue Aug 4, 2015 · 1 comment
Labels
type: bug

Comments

@miketaylr
Copy link
Member

Currently if you have a label with a namespace (status- or browser-) and open the label editor, it won't know how to check the current labels, so it checks none. If you close, that means it saves the issue with no labels.
miketaylr pushed a commit that referenced this issue Aug 4, 2015
Issue #658. Remove label namespaces so they can be properly checked i…
50dd910 
…n editLabels.
@miketaylr
Copy link
Member Author

No tests yet. Those will come in #272.

NOTE: We'll refactor this so we're doing these conversions at the model level, just before and after talking to the API.

🏥

@karlcow karlcow closed this as completed in 9eb1622 Aug 4, 2015
miketaylr pushed a commit that referenced this issue Aug 12, 2015
Issue #658. Remove label namespaces so they can be properly checked i…
42d8eff 
…n editLabels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miketaylr