Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard navigation and focus #907

Closed
karlcow opened this issue Jan 28, 2016 · 7 comments
Closed

Keyboard navigation and focus #907

karlcow opened this issue Jan 28, 2016 · 7 comments
Assignees
@magsout
Labels
prio: good first bug type: bug type: design

Comments

@karlcow
Copy link
Member

karlcow commented Jan 28, 2016

I was working on this webcompat issue when I tried to navigate the webcompat page with tab. And I have the feeling we do a poor job at it too.
@magsout
Copy link
Member

magsout commented Jan 28, 2016

you are absolutely right.

@magsout magsout self-assigned this Jan 28, 2016
@magsout
Copy link
Member

magsout commented Jan 28, 2016

what I suggest is to double in 90% of the case :hover with :focus.

@magsout
Copy link
Member

magsout commented Jan 28, 2016

10% is special case where hover and focus have no sense

magsout added a commit that referenced this issue Feb 4, 2016
@magsout
issue #907 - added focus event
5af80fc
karlcow added a commit that referenced this issue Feb 4, 2016
@karlcow
Merge pull request #910 from webcompat/keyboard-navigation-focus
a45e1bb 
issue #907 - added focus event
@magsout
Copy link
Member

magsout commented Mar 6, 2016

@karlcow you think we need something more for Keyboard navigation and focus ?

@karlcow
Copy link
Member Author

karlcow commented Mar 7, 2016

@magsout do a pull request on this one. And if other issues surface in the future, will create another issues. Small steps. :)

@magsout
Copy link
Member

magsout commented Mar 8, 2016

@karlcow yes, I did it 5af80fc and already merged

@miketaylr
Copy link
Member

Seems like this one is fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magsout magsout

Labels
prio: good first bug type: bug type: design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@miketaylr @karlcow @magsout