Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a nicer looking error message for "image is too big" error #995

Closed
miketaylr opened this issue Apr 5, 2016 · 5 comments
Closed

Make a nicer looking error message for "image is too big" error #995

miketaylr opened this issue Apr 5, 2016 · 5 comments
Assignees

Comments

@miketaylr
Copy link
Member

Right now it looks hilariously bad, but it's still an improvement over a nginx 413 page.

@magsout, would it be possible to make a red banner with white text similar to the "Remove Image Upload" banner we have?

(It wouldn't need to be a button, just plain text should be OK i think?)

@karlcow
Copy link
Member

karlcow commented Apr 5, 2016

Heh. Hilariously bad could be moved to hilariously funny. ❓
Like the fly from the lightbulb who would have eaten too much.
But as a first step. The submit button should be blocked and maybe the message should be inside the yellow area.

@miketaylr
Copy link
Member Author

Hehe, I like the idea of using a stuffed fly. 🍕 🐝

But as a first step. The submit button should be blocked and maybe the message should be inside the yellow area.

Agreed. #996 makes the submits disabled. I was also thinking we could maybe change the yellow area to be red, with white text containing the error message.

@magsout
Copy link
Member

magsout commented Apr 8, 2016

Message error in red at the bottom.
Close button on top/right

capture d ecran 2016-04-08 a 09 03 31

@miketaylr
Copy link
Member Author

Looks nice! I wonder if we can remove the close image, or at least make "choose an image" a hyperlink (or something that looks like a hyperlink, could be a button) that opens the image picker.

Or maybe the close image button also opens the file picker too?

@magsout
Copy link
Member

magsout commented Apr 13, 2016

Looks nice! I wonder if we can remove the close image, or at least make "choose an image" a hyperlink (or something that looks like a hyperlink, could be a button) that opens the image picker.

Ah yes, good point. Hum So icon is not enough and revelant..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants