Fixes #890. Remove intermittent failing search tests.

[miketaylr]

It dawned on me that the reason these sometimes fail is because of Search API rate limits (non-authed tests are sending requests from the Travis IP, not the authed webcompat proxy).

If that theory is true, then moving the "search works" to the auth tests should never fail (which is good, because we don't lose test coverage -- sort of).

r? @karlcow

[miketaylr]

Erm.

FAIL: main - Search (auth) - Search works (3577ms)

AssertionError: The search results show up on the page.: expected 'Issue 280: w3.org - desktop site instead of mobile site' to include 'vladvlad'

[karlcow]

ok I have 3 failed tests.

Let see:

× firefox 45.0.2 on MAC - Issues (auth) - Closing and reopening an issue
× firefox 45.0.2 on MAC - Reporting (non-auth) - Problem type validation
× firefox 45.0.2 on MAC - Reporting (non-auth) - URL validation

hmm not related to your modifications at least.
Let me try again.

grmph

× firefox 45.0.2 on MAC - Issues (auth) - Closing and reopening an issue
AssertionError: Closed state text is displayed: expected 'Ready for Outreach' to equal 'Closed'
× firefox 45.0.2 on MAC - Search (auth) - Search works
AssertionError: The search results show up on the page.: expected 'Issue 369: www.testing-things.com - mobile site is not usable' to include 'vladvlad'

[karlcow]

so unstable these tests… Sniff. 💣

[miketaylr]

so unstable these tests… Sniff. 💣

Yeah. It really sucks. :(

[miketaylr]

ok I have 3 failed tests.

And yet Travis likes all the tests: https://travis-ci.org/webcompat/webcompat.com/builds/126474683

Feels like playing Russian roulette. 🔫

[karlcow]

ok let's merge. Something to discuss in London or somewhere. In the same bucket of fixtures and Mocking.

[karlcow]

Thanks @miketaylr 💡