Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #977 - Added Mozilla Public License 2.0 to Package.json #1038

Merged
merged 1 commit into from
May 3, 2016

Conversation

deepthivenkat
Copy link
Member

No description provided.

@miketaylr
Copy link
Member

I can't merge in this commit unless it's in a pull request. :)

Ah, now I see why I was confused. You asked for review on a specific commit, not on the PR (and it ended up in my reviews filter). In the future, you can ask for review when you're creating the PR. 👍

@miketaylr miketaylr changed the title Issue #977 - Added Mozilla Public License 2.0 to Package.json Fixes #977 - Added Mozilla Public License 2.0 to Package.json May 3, 2016
@miketaylr
Copy link
Member

(one more tiny hint for the future, the PR title should be "Fixes #977 - Blah blah blah" -- that way when it's merged it will automatically close #977)

I'll update https://github.com/webcompat/webcompat.com/blob/master/CONTRIBUTING.md#submission-guidelines so that's more explicit. It's in the example but not super clear.

@miketaylr miketaylr merged commit e1f474f into webcompat:master May 3, 2016
@deepthivenkat deepthivenkat deleted the Issue#977 branch July 5, 2016 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants