-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1043. Add first parts of func test suite for image uploads. #1048
Conversation
(holding off on review, I want to see if this timeout failure happens again on Travis -- this passes locally for me) |
I need to look at this again after the fix for #1049 lands -- things have changed. |
r? @karlcow -- we obviously need to add tests for issue image uploads and "regular" file uploads as well. probably a good task for @deepthivenkat :) |
grmph First pass
Second passLet's try another one. :)
@miketaylr |
They pass for me locally. :/ Don't worry about spending more time on this for now, I'll come back to it. |
(also thanks for attempting review!) |
(Also, they passed on Travis.) |
Test case : Image Uploads (non-auth) - postMessaged dataURI image
|
ah @deepthivenkat has a similar failure. Hypothesis. The setup we are using for working is different. Or the way we proceed for starting the tests. Or… another silly theory… network issues, aka @miketaylr is "local" and we are "distant". |
I will merge because it's working on Travis, but it would be good to figure out what's happening. |
This tests showing and removing image previews of screenshots that come from add-ons.