Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1043. Add first parts of func test suite for image uploads. #1048

Merged
merged 1 commit into from
May 29, 2016

Conversation

miketaylr
Copy link
Member

This tests showing and removing image previews of screenshots that come from add-ons.

@miketaylr
Copy link
Member Author

(holding off on review, I want to see if this timeout failure happens again on Travis -- this passes locally for me)

@miketaylr
Copy link
Member Author

I need to look at this again after the fix for #1049 lands -- things have changed.

@miketaylr
Copy link
Member Author

r? @karlcow -- we obviously need to add tests for issue image uploads and "regular" file uploads as well. probably a good task for @deepthivenkat :)

@karlcow
Copy link
Member

karlcow commented May 26, 2016

grmph

First pass

capture d ecran 2016-05-26 a 09 58 44

× firefox 46.0.1 on MAC - Image Uploads (non-auth) - postMessaged dataURI image upload worked
× firefox 46.0.1 on MAC - Issues - Issue page loads
× firefox 46.0.1 on MAC - Search (auth) - Search from the homepage
× firefox 46.0.1 on MAC - Search (auth) - Search/filter interaction

Second pass

Let's try another one. :)

capture d ecran 2016-05-26 a 10 10 25

× firefox 46.0.1 on MAC - Search (auth) - Search works
× firefox 46.0.1 on MAC - Issues - Issue page loads
× firefox 46.0.1 on MAC - Image Uploads (non-auth) - postMessaged dataURI image upload worked

@miketaylr × firefox 46.0.1 on MAC - Image Uploads (non-auth) - postMessaged dataURI image upload worked seems to fail consistently. What's happening for your when running locally.

@miketaylr
Copy link
Member Author

They pass for me locally. :/

Don't worry about spending more time on this for now, I'll come back to it.

@miketaylr
Copy link
Member Author

(also thanks for attempting review!)

@miketaylr
Copy link
Member Author

All checks have passed

(Also, they passed on Travis.)

@deepthivenkat
Copy link
Member

deepthivenkat commented May 27, 2016

Test case : Image Uploads (non-auth) - postMessaged dataURI image

  1. First Test : Failed on 27th may
    https://gist.github.com/deepthivenkat/d3c7f36db8259a92327b5688ed5e6d12
  2. Second Test : Passed on 29th may
    https://gist.github.com/deepthivenkat/37ffc6a09504002ba3cb7f6e749c80f6

@karlcow
Copy link
Member

karlcow commented May 29, 2016

ah @deepthivenkat has a similar failure. Hypothesis. The setup we are using for working is different. Or the way we proceed for starting the tests.

Or… another silly theory… network issues, aka @miketaylr is "local" and we are "distant".

@karlcow
Copy link
Member

karlcow commented May 29, 2016

I will merge because it's working on Travis, but it would be good to figure out what's happening.

@karlcow karlcow merged commit 10889e1 into master May 29, 2016
@zoepage zoepage deleted the issues/1043/1 branch July 10, 2017 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants