Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1001. Hide NSFW images by default. #1087

Merged
merged 5 commits into from
Jun 25, 2016
Merged

Fixes #1001. Hide NSFW images by default. #1087

merged 5 commits into from
Jun 25, 2016

Conversation

miketaylr
Copy link
Member

(I just realized, this only works for issues with a "nsfw" label already applied. Follow up bug #1086 was filed to make it work as soon as you apply the label)

r? @magsout for CSS
r? @hallvors for JS

@miketaylr
Copy link
Member Author

Ah, need to add fixture data for this:

IOError: [Errno 2] No such file or directory: u'/home/travis/build/webcompat/webcompat.com/tests/fixtures/api/issues/396.json'

@miketaylr
Copy link
Member Author

gif (ignore the compression artifacts)

nsfw

@magsout
Copy link
Member

magsout commented Jun 10, 2016

My first review for the mozLondon week ? 👍

@miketaylr
Copy link
Member Author

My first review for the mozLondon week ? 👍

Heh yeah, no rush!

_.each([this.title, this.metadata, this.body, this.labels,
// _.find() will return the object if found (which is truthy),
// or undefined if not found (which is falsey)
this._isNSFW = _.find(this.issue.get('labels'),

This comment was marked as abuse.

This comment was marked as abuse.

@magsout
Copy link
Member

magsout commented Jun 11, 2016

Except for className, lgtm, nice work @miketaylr

@hallvors
Copy link
Contributor

Indeed, 🆙

@miketaylr
Copy link
Member Author

Cool, thx for review @hallvors and @magsout. Given a few minutes I'll push the follow up commits here.

@hallvors
Copy link
Contributor

Travis seems unhappy about new test(s)?

FAIL: main - Issues - Clicking NSFW images toggles between blurry and not-blurry (1488ms)
AssertionError: expected '.wc-Comment-content-nsfw' to include 'wc-Comment-content-nsfw--display'

@miketaylr
Copy link
Member Author

Travis seems unhappy about new test(s)?

Yeah, hmm. Let me re-test locally and see what's up.

@miketaylr
Copy link
Member Author

Bah, finally fixed the error of the failing test -- I had a stray . in addClass, so, yay, failing tests revealed a bug. All green now, so let's merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants