-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1001. Hide NSFW images by default. #1087
Conversation
Ah, need to add fixture data for this:
|
My first review for the mozLondon week ? 👍 |
Heh yeah, no rush! |
_.each([this.title, this.metadata, this.body, this.labels, | ||
// _.find() will return the object if found (which is truthy), | ||
// or undefined if not found (which is falsey) | ||
this._isNSFW = _.find(this.issue.get('labels'), |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Except for |
Indeed, 🆙 |
… has been labeled as such.
Travis seems unhappy about new test(s)? FAIL: main - Issues - Clicking NSFW images toggles between blurry and not-blurry (1488ms) |
Yeah, hmm. Let me re-test locally and see what's up. |
Bah, finally fixed the error of the failing test -- I had a stray |
(I just realized, this only works for issues with a "nsfw" label already applied. Follow up bug #1086 was filed to make it work as soon as you apply the label)
r? @magsout for CSS
r? @hallvors for JS