Fixes #1058 - Fetching and rendering all comments #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
deepthivenkat
commented
Jul 6, 2016
deepthivenkat
commented
- Fetch and Render page 1 (30 comments)
- Get last page number from response header of page 1
- Fetch and render remaining comments from page 2 to last page
|
r? @miketaylr |
| @@ -371,7 +371,8 @@ issues.MainView = Backbone.View.extend({ | |||
| $(document.body).addClass('language-html'); | |||
| var issueNum = {number: issueNumber}; | |||
| this.issue = new issues.Issue(issueNum); | |||
| this.comments = new issues.CommentsCollection([]); | |||
| this.commentPage = {page: 1}; | |||
| this.comments = new issues.CommentsCollection([this.commentPage]); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
This looks good! I think we can simplify some things further (and rename some stuff so it's more clear, e.g. Here's a diff of how we can make this a bit easier to read/understand: https://gist.github.com/miketaylr/01b9f090dda8c6e928d40c7eb08081c5 |
|
(Also, I don't see the double download issue anymore -- cool that you fixed it!)
|
|
@miketaylr I have added the review changes |
|
@deepthivenkat can you please change the commit message to match conventions (or rebase/fixup it into the previous commit)? (there's also a typo "reiew comments") |
deepthivenkat
force-pushed
the
issues/1058/1
branch
from
4b3e78f to
7872305
Compare
… review comments
|
Done @miketaylr |
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.