Fixes #1120 - Add status code 301 and redirect url for /issues/catego… #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepthivenkat
force-pushed
the
issues/1120/2
branch
from
6639edc to
9e5fd0e
Compare
| @@ -128,7 +130,7 @@ def get_issue_category(issue_category): | |||
| # For paginated results on the /issues page, | |||
| # see /issues/search/needstriage. | |||
| elif issue_category == 'new': | |||
| abort(301) | |||
| redirect(url_for('.get_issue_category', issue_category='needstriage'), 301) | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
deepthivenkat
force-pushed
the
issues/1120/2
branch
from
9e5fd0e to
b6c9a63
Compare
…es/category/new to /issues/category/needstriage, /issues/search/new to /issues/search/needtriage
|
@deepthivenkat was there a question here? GitHub sent me a notification from a commit, but when I click on it it says "We went looking everywhere, but couldn’t find those commits." |
| @@ -128,7 +130,8 @@ def get_issue_category(issue_category): | |||
| # For paginated results on the /issues page, | |||
| # see /issues/search/needstriage. | |||
| elif issue_category == 'new': | |||
| abort(301) | |||
| redirect(url_for('.get_issue_category', | |||
| issue_category='needstriage'), 301) | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
deepthivenkat
force-pushed
the
issues/1120/2
branch
from
0c3b10f to
5dd4e21
Compare
…y and prepend api. to the method inside url_for
|
r+ (review request here: #1120 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ry/new to /issues/category/needstriage, /issues/search/new to /issues/search/needtriage