Fixes 646: kill Thanks page (and move it into a flash message of new issue)

[miketaylr]

r? @magsout for CSS
r? @karlcow for Python

Not sure we want to merge just yet, it's sort of ugly. I'd like Mesha to do a UX review of the copy as well -- suggestions for words or design welcome from anyone!

(edit: also ignore that the header isn't styled -- that's taken care of in #1246)

[miketaylr]

Oops:

FAIL: Test that /thanks/1 exists.

[karlcow]

Everything looks good under the hood. r+ @miketaylr

[adamopenweb]

Pinging @lockettm. Can you take a quick look at this please? Would love to have your feedback. :)

[miketaylr]

(also, the "Complain on Facebook" text is a joke)

[lockettm]

Copy looks good.

I kind of like the "Complain on Facebook" text. :) If we want to add more context to the "Share on Twitter" and "Share on Facebook" buttons, a line above stating "Tell your friends about the bug you just filed," might work.

This could also be an opportunity to further engage users--explain what happens next and invite them to join the team. However, if the main goal is to get them to share on social media, this may split their attention.

[miketaylr]

Thanks for reviewing!

This could also be an opportunity to further engage users--explain what happens next and invite them to join the team. However, if the main goal is to get them to share on social media, this may split their attention.

Yeah, I agree this is a good spot to recommend next steps and give suggestions on how they can help, etc. Let's file a bug to add that kind of stuff after we ship the simple version.

[magsout]

good idea @miketaylr
👍

[miketaylr]

OK, here we are. There's lots of room for improvement -- please file bugs and send PRs to make it better!

Thanks @karlcow @lockettm @magsout for review!