Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1249: support a src param to track "reported-with" #1255

Merged
merged 2 commits into from
Dec 28, 2016
Merged

Fixes #1249: support a src param to track "reported-with" #1255

merged 2 commits into from
Dec 28, 2016

Conversation

miketaylr
Copy link
Member

@miketaylr miketaylr requested a review from karlcow December 24, 2016 00:04
miketaylr
miketaylr commented Dec 24, 2016
View reviewed changes
webcompat/static/js/lib/bugform.js
@@ -142,7 +142,7 @@ function BugForm() {
if (!location.search.search(/open=1/) && !location.search.search(/url=/)) {
return;
}
var urlParam = location.search.match(/url=(.+)/);
var urlParam = location.search.match(/url=([^&]*)/);

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

karlcow
karlcow requested changes Dec 28, 2016
View reviewed changes
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. A question for the url containing &
  2. A change for the python code which will not work as you expect.

webcompat/views.py
# See https://github.com/webcompat/webcompat.com/issues/1254 to track
# supporting only the src param
if session['src']:
form['reported_with'] = session.pop('src', None)

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

webcompat/static/js/lib/bugform.js
@@ -142,7 +142,7 @@ function BugForm() {
if (!location.search.search(/open=1/) && !location.search.search(/url=/)) {
return;
}
var urlParam = location.search.match(/url=(.+)/);
var urlParam = location.search.match(/url=([^&]*)/);

This comment was marked as abuse.

Sign in to view

@miketaylr
Copy link
Member Author

A question for the url containing &

Answered here: #1255 (comment) (and another question for you).

A change for the python code which will not work as you expect.

Done, thank you!

@karlcow
Copy link
Member

karlcow commented Dec 28, 2016

Thanks @miketaylr

@karlcow karlcow merged commit 22967c9 into master Dec 28, 2016
@karlcow karlcow mentioned this pull request Feb 8, 2017
Merged
@zoepage zoepage deleted the issues/1249/1 branch March 3, 2017 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlcow karlcow karlcow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miketaylr @karlcow