Fixes #1582 - Gets mock login to work #1588
Conversation
|
I just saw that along with this commit there is a package-lock.json file. I never saw that, but from a quick Google search I saw that it should be ignored... Should we add it to .gitignore? I can open a new issue for that. |
package-lock.json
Outdated
| @@ -0,0 +1,5268 @@ | |||
| { | |||
| "name": "webcompat", | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
webcompat/views.py
Outdated
| return github.authorize('public_repo') | ||
| if app.config['TESTING']: | ||
| session['username'] = 'testuser' | ||
| session['avatar_url'] = '/img/avatar.png?' |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
oops, I should have read this question before commenting as much in review. Yeah, let's remove it and add a commit to .gitignore it. |
Let's open a new issue for that, and list which tests require network access.
Yeah, there should be a way to detect that we're in test mode, and just return some JSON fixture file that has the right content. |
|
r? @miketaylr Let me know if you find anything else I need to change. I tested and everything seems to be working fine, but since I started using the notebook that Mozilla sent I have been getting the #1569 error, so I wasn't able to run all tests... |
|
@brizental can you rebase and push your branch back up before we merge this in?
|
|
ok, looks good! i rebased everything down to a single commit. let's talk about rebasing commits in our next 1:1. it's possible to do some cool stuff. :) (but sometimes it can get crazy....) |
| else: | ||
| # manually set the referer so we know where to come back to | ||
| # when we return from GitHub | ||
| set_referer(request) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
So, I got mock login to work. I don't know if this is the best way, but it works. Let me know what you guys think.
The login is working, but the user activity page is not, it gets a "Bad credentials" error. I'll work on that tomorrow. I think it should be something close to what we already do with the issues fixtures.
Also, I noticed that even though now the login doesn't require remote server requests, there are some other tests that still do. Maybe it would be best to change this issue's name to "Get all tests to work offline" or something. What do you think?
Anyways, r? @miketaylr