Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1719 - Removes unused issues.db from the code #1720

Merged
merged 2 commits into from
Aug 24, 2017
Merged

Fixes #1719 - Removes unused issues.db from the code #1720

merged 2 commits into from
Aug 24, 2017

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Aug 17, 2017 •
edited
Loading

  • It also cleans up a bit the syntax. Preparing for linting and future pep stuff.
  • It changes a bit the logic on run.py. It became obvious that we were not checking dependencies when in test mode (ooops)

@miketaylr r?

karlcow added 2 commits August 17, 2017 10:03
@karlcow
Issue webcompat#1719 - Fixes syntax
9ba9233 
- pep257 for docstrings Issue webcompat#1473
- order of imports
- Adding nopep8 for import
@karlcow
Issue webcompat#1719 - Removes unused issues.db code
72be3b1 
- removes the initialisation for issues.db
- removes the backup feature for issues.db
- rearrange the logic for testing mode and checking dependencies
@karlcow karlcow requested a review from miketaylr August 17, 2017 01:07
This was referenced Aug 17, 2017
Closed
Closed
miketaylr
miketaylr approved these changes Aug 21, 2017
View reviewed changes
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor question about import order... feel free to merge after fixing (or answering why it doesn't need to be fixed).

webcompat/db/__init__.py
@@ -4,15 +4,18 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

"""Databases initialization."""

from hashlib import sha512

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

run.py
# in test mode everything must be mocked,
# so there is no external api communication.
config_validator()
app.run(host='localhost')

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@karlcow
Copy link
Member Author

karlcow commented Aug 24, 2017

@miketaylr It's mergeable. :)

@karlcow karlcow merged commit ffb0dc3 into webcompat:master Aug 24, 2017
@karlcow karlcow deleted the 1719/1 branch August 24, 2017 05:41
@karlcow
Copy link
Member Author

karlcow commented Aug 24, 2017

(merged myself because @miketaylr is traveling and approved.)

@karlcow karlcow mentioned this pull request Aug 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlcow @miketaylr