Some functional Tests for issues #276
Conversation
|
Do these work for you locally? I'm running into an issue with Intern/Selenium not being able to read the session cookie so logging in on a non-index page doesn't work--you should only be able to open/close issues when you're authed. |
|
No I haven't tried to make them work yet. I was trying to figure out the syntax. |
|
Just to comment here - I need to solve #277 before we can merge in these tests. Right now there's no way for them to pass, but it's not because they're bad tests. Hopefully we can get the testing issues figured out sooner than later. |
|
ok I should try to finish these tests now that we have figured out why it was failing. |
| assert.equal(text, "Reopen issue"); | ||
| }) | ||
| .end(); | ||
| }) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I just cherry picked these commits (merging against my branch ended up in a ton of conflicts--you might rebase your branch against master for less problems), but didn't get them to run because of the small syntax mistakes. I would double check that the selectors are still valid--@magsout has done a lot of CSS refactoring since the original PR. It might be easier to create a new branch once the login stuff is pulled. 🌹 |
|
Just a note -- when #415 is merged, you can run |
Definitely. Thanks for the review. |
|
I'm going to close this pull request, but please reopen once you have your updated tests. Thanks! |
Still a couple missing.