Handle login redirects via Referer not ?next param. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 18, 2014 22:19
No longer need to check ?next_url, which was done insecurely.
miketaylr
pushed a commit
that referenced
this pull request
Sep 22, 2014
Handle login redirects via Referer not ?next param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot going on in this branch... I didn't do a good job of keeping it very clean.
But basicaly this redoes the way we handle redirects after logging in to use Referer header rather than blindly accept
?nextparam (which can be a security problem).There's some tweaks to tests which are related-ish to the main problem of not being able to log in from a non-index page in tests. That problem isn't solved yet.