Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2741 - Changes text "Reproduce a Bug" to text "Triage a Bug" #2987

Merged
merged 6 commits into from
Oct 22, 2019
Merged

Fixes #2741 - Changes text "Reproduce a Bug" to text "Triage a Bug" #2987

merged 6 commits into from
Oct 22, 2019

Conversation

pachicodes
Copy link
Contributor

@pachicodes pachicodes commented Oct 20, 2019

This PR fixes issue #2741

Proposed PR background

This changes the text in the documentation.

Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pachicodes Thanks for the pull request.

There are a couple of things which are not following the contribution guidelines.

  1. Title of the pull request
  2. Commit messages missing the issue number.
  3. The pull request initial message not filed.

Once you made the modification did you test that it was working? By clicking on the link?

webcompat/templates/contributors/sub-nav.html Outdated Show resolved Hide resolved
webcompat/templates/shared/footer.html Outdated Show resolved Hide resolved
@pachicodes
Copy link
Contributor Author

Sorry about, that is one of my first contributions so I am still getting used to it.
Thank you for explaining, I will be more careful and make the changes,

@miketaylr
Copy link
Member

miketaylr commented Oct 21, 2019

Sorry about, that is one of my first contributions so I am still getting used to it.

No need to apologize!

#2741 is the issue you're working on, so when we submit pull requests we do a few things:

In the PR title we write something like Fixes #2751 - (...short description of PR...). You should be able to edit the title up top here in the PR.

In our commit messages we reference the issue we're fixing, not the PR. So like you've done, but Issue #2751 - Change ..... It looks like you've edited commit messages already, but let me know if you need help figuring out how to do this. Sometimes it can get painful...

@pachicodes pachicodes changed the title Change Reproduce a Bug with Triage a Bug Fixes #2751 - Changes text "Reproduce a Bug" to text "Triage a Bug" Oct 21, 2019
@pachicodes pachicodes changed the title Fixes #2751 - Changes text "Reproduce a Bug" to text "Triage a Bug" Fixes #2741 - Changes text "Reproduce a Bug" to text "Triage a Bug" Oct 21, 2019
@pachicodes
Copy link
Contributor Author

@miketaylr I think it is right now, would you mind checking it when you have some time? Thank you!!!

@karlcow
Copy link
Member

karlcow commented Oct 22, 2019

ok let's see. The tests are failing. Let's check if it's the code or just a glitch in CircleCI.

× firefox on linux 4.15.0-1043-aws - Search (auth) - Search from the homepage (1.484s)
    Error: [POST http://localhost:4444/wd/hub/session/60896241-5f74-4e82-801b-630331d1f4e6/element/2770c5f7-3b4e-492f-9716-abef45f8fd12/click / {}] Element <input class="form-field text-field" name="q"> could not be scrolled into view
    Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:25:53'
    System info: host: 'cfe3749e2da6', ip: '172.23.0.3', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-1043-aws', java.version: '11.0.3'
    Driver info: driver.version: unknown
      at Test.Search from the homepage [as test] @ tests/functional/search-auth.js:151:12
      @ src/lib/Test.ts:263:51

@pachicodes This is unrelated to your modifications. So this is a glitch.
Let's run the workflow again.
https://circleci.com/gh/webcompat/webcompat.com/742
OK All green!

Thanks for taking time to make it better. Really appreciated.

@karlcow karlcow merged commit e62c147 into webcompat:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants